From 06ca8b102609a77efb3d18f2e982ca670bb83dc6 Mon Sep 17 00:00:00 2001
From: Sathya Gunasekaran <gsathya.ceg@gmail.com>
Date: Thu, 24 Nov 2022 15:28:38 +0000
Subject: [PATCH] [playground] Refactor compilation of HIR

Stack created with [Sapling](https://sapling-scm.com). Best reviewed with
[ReviewStack](https://reviewstack.dev/facebook/react-forget/pull/825). * __->__
#825

[playground] Refactor compilation of HIR
---
 .../playground/components/Editor/Output.tsx   | 167 +++++++++++-------
 1 file changed, 102 insertions(+), 65 deletions(-)

diff --git a/compiler/forget/packages/playground/components/Editor/Output.tsx b/compiler/forget/packages/playground/components/Editor/Output.tsx
index 2530d77ccf..7dfa2542e5 100644
--- a/compiler/forget/packages/playground/components/Editor/Output.tsx
+++ b/compiler/forget/packages/playground/components/Editor/Output.tsx
@@ -10,7 +10,7 @@ import MonacoEditor from "@monaco-editor/react";
 import { Diagnostic, HIR, OutputKind } from "babel-plugin-react-forget";
 import prettier from "prettier";
 import prettierParserBabel from "prettier/parser-babel";
-import { memo } from "react";
+import { memo, useMemo } from "react";
 import type { Store } from "../../lib/stores";
 import TabbedWindow from "../TabbedWindow";
 import { monacoOptions } from "./monacoOptions";
@@ -36,14 +36,26 @@ type Props = {
   updateDiagnostics: (newDiags: Diagnostic[]) => void;
 };
 
-// TODO(gsn: Update diagnostics ƒrom HIR output
-function Output({ store }: Props) {
-  const astFunctions = parseFunctions(store.source);
-  if (astFunctions.length === 0) {
-    return <div></div>;
-  }
+type CompilerOutput = {
+  ssaOutput: string;
+  hirOutput: string;
+  eliminateRedundantPhiOutput: string;
+  inferReferenceEffectsOutput: string;
+  inferMutableRangesOutput: string;
+  leaveSSAOutput: string;
+  codegenOutput: string;
+  sourceMapUrl: string | null;
+};
 
+type CompilerError = string;
+
+function compile(source: string): CompilerOutput | CompilerError {
   try {
+    const astFunctions = parseFunctions(source);
+    if (astFunctions.length === 0) {
+      return "";
+    }
+
     // TODO: Handle multiple functions
     const func = astFunctions[0];
     const env = new Environment();
@@ -74,7 +86,7 @@ function Output({ store }: Props) {
         sourceMaps: true,
         sourceFileName: "input.js",
       },
-      store.source
+      source
     );
     const sourceMapUrl = getSourceMapUrl(
       generated.code,
@@ -85,67 +97,92 @@ function Output({ store }: Props) {
       parser: "babel",
       plugins: [prettierParserBabel],
     });
-    return (
-      <TabbedWindow
-        defaultTab="HIR"
-        tabs={{
-          HIR: (
-            <TextTabContent
-              output={hirOutput}
-              kind={OutputKind.IR}
-            ></TextTabContent>
-          ),
-          SSA: (
-            <TextTabContent
-              output={ssaOutput}
-              kind={OutputKind.IR}
-            ></TextTabContent>
-          ),
-          EliminateRedundantPhi: (
-            <TextTabContent
-              output={eliminateRedundantPhiOutput}
-              kind={OutputKind.IR}
-            ></TextTabContent>
-          ),
-          InferReferenceEffects: (
-            <TextTabContent
-              output={inferReferenceEffectsOutput}
-              kind={OutputKind.IR}
-            ></TextTabContent>
-          ),
-          InferMutableRanges: (
-            <TextTabContent
-              output={inferMutableRangesOutput}
-              kind={OutputKind.IR}
-            ></TextTabContent>
-          ),
-          LeaveSSA: (
-            <TextTabContent
-              output={leaveSSAOutput}
-              kind={OutputKind.IR}
-            ></TextTabContent>
-          ),
-          JS: <TextTabContent output={codegenOutput} kind={OutputKind.JS} />,
-          SourceMap: (
-            <>
-              {" "}
-              {sourceMapUrl && (
-                <iframe
-                  src={sourceMapUrl}
-                  className="w-full h-96"
-                  title="Generated Code"
-                />
-              )}
-            </>
-          ),
-        }}
-      />
-    );
+
+    return {
+      hirOutput,
+      ssaOutput,
+      eliminateRedundantPhiOutput,
+      inferReferenceEffectsOutput,
+      inferMutableRangesOutput,
+      leaveSSAOutput,
+      codegenOutput,
+      sourceMapUrl,
+    };
   } catch (e: any) {
-    return <div>error: ${e.toString()}</div>;
+    return e.toString();
   }
 }
 
+// TODO(gsn: Update diagnostics ƒrom HIR output
+function Output({ store }: Props) {
+  const compilerOutput = useMemo(() => compile(store.source), [store.source]);
+  if (typeof compilerOutput === "string") {
+    if (compilerOutput === "") return <div></div>;
+    return <div>error: ${compilerOutput}</div>;
+  }
+
+  return (
+    <TabbedWindow
+      defaultTab="HIR"
+      tabs={{
+        HIR: (
+          <TextTabContent
+            output={compilerOutput.hirOutput}
+            kind={OutputKind.IR}
+          ></TextTabContent>
+        ),
+        SSA: (
+          <TextTabContent
+            output={compilerOutput.ssaOutput}
+            kind={OutputKind.IR}
+          ></TextTabContent>
+        ),
+        EliminateRedundantPhi: (
+          <TextTabContent
+            output={compilerOutput.eliminateRedundantPhiOutput}
+            kind={OutputKind.IR}
+          ></TextTabContent>
+        ),
+        InferReferenceEffects: (
+          <TextTabContent
+            output={compilerOutput.inferReferenceEffectsOutput}
+            kind={OutputKind.IR}
+          ></TextTabContent>
+        ),
+        InferMutableRanges: (
+          <TextTabContent
+            output={compilerOutput.inferMutableRangesOutput}
+            kind={OutputKind.IR}
+          ></TextTabContent>
+        ),
+        LeaveSSA: (
+          <TextTabContent
+            output={compilerOutput.leaveSSAOutput}
+            kind={OutputKind.IR}
+          ></TextTabContent>
+        ),
+        JS: (
+          <TextTabContent
+            output={compilerOutput.codegenOutput}
+            kind={OutputKind.JS}
+          />
+        ),
+        SourceMap: (
+          <>
+            {compilerOutput.sourceMapUrl && (
+              <iframe
+                src={compilerOutput.sourceMapUrl}
+                className="w-full h-96"
+                title="Generated Code"
+              />
+            )}
+          </>
+        ),
+      }}
+    />
+  );
+}
+
 function utf16ToUTF8(s: string): string {
   return unescape(encodeURIComponent(s));
 }