mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Eloy Durán
25571ec452
Summary: When building as a framework these headers get automatically added to the framework umbrella header for React-Core. Instead of converting all the React sources to ObjC++ files and still forcing external users that build native source (and link against a framework build) to also compile as ObjC++, this makes the attribution related methods that were added in https://github.com/facebook/react-native/commit/fdcdca4 opt-in to ObjC++ builds. This is also the reason for the current failure of the CI `test_ios_frameworks` run. ## Changelog I’m unsure if this change really warrants an entry in the CHANGELOG, as it’s more of an amendment of the (afaik) unreleased [change](https://github.com/facebook/react-native/commit/fdcdca4). [iOS] [Fixed] - Make framework builds work again by making `RCTImageLoader` C++ requirement opt-in Pull Request resolved: https://github.com/facebook/react-native/pull/27730 Test Plan: I tested static and dynamic (framework) builds and ran the test suite. This change should make the `test_ios_frameworks` CI run _build_ again, ~~but it may still fail overall as in my local testing one of the tests leads to a segfault (which I will try to address separately)~~. Reviewed By: PeteTheHeat Differential Revision: D19348846 Pulled By: fkgozali fbshipit-source-id: 8a74e6f7ad3ddce2cf10b080b9a5d7b399bd5fc0
74 lines
2.6 KiB
Objective-C
74 lines
2.6 KiB
Objective-C
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <React/RCTImageURLLoader.h>
|
|
|
|
// TODO (T61325135): Remove C++ checks
|
|
#ifdef __cplusplus
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
struct ImageURLLoaderAttribution {
|
|
int32_t nativeViewTag = 0;
|
|
int32_t surfaceId = 0;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|
|
#endif
|
|
|
|
@interface RCTImageURLLoaderRequest : NSObject
|
|
|
|
@property (nonatomic, strong, readonly) NSString *requestId;
|
|
@property (nonatomic, strong, readonly) NSURL *imageURL;
|
|
@property (nonatomic, copy, readonly) RCTImageLoaderCancellationBlock cancellationBlock;
|
|
|
|
- (instancetype)initWithRequestId:(NSString *)requestId imageURL:(NSURL *)imageURL cancellationBlock:(RCTImageLoaderCancellationBlock)cancellationBlock;
|
|
- (void)cancel;
|
|
|
|
@end
|
|
|
|
/**
|
|
* Same as the RCTImageURLLoader interface, but allows passing in optional `attribution` information.
|
|
* This is useful for per-app logging and other instrumentation.
|
|
*/
|
|
@protocol RCTImageURLLoaderWithAttribution <RCTImageURLLoader>
|
|
|
|
// TODO (T61325135): Remove C++ checks
|
|
#ifdef __cplusplus
|
|
/**
|
|
* Same as the RCTImageURLLoader variant above, but allows optional `attribution` information.
|
|
* Caller may also specify a preferred requestId for tracking purpose.
|
|
*/
|
|
- (RCTImageURLLoaderRequest *)loadImageForURL:(NSURL *)imageURL
|
|
size:(CGSize)size
|
|
scale:(CGFloat)scale
|
|
resizeMode:(RCTResizeMode)resizeMode
|
|
requestId:(NSString *)requestId
|
|
attribution:(const facebook::react::ImageURLLoaderAttribution &)attribution
|
|
progressHandler:(RCTImageLoaderProgressBlock)progressHandler
|
|
partialLoadHandler:(RCTImageLoaderPartialLoadBlock)partialLoadHandler
|
|
completionHandler:(RCTImageLoaderCompletionBlock)completionHandler;
|
|
#endif
|
|
|
|
/**
|
|
* Image instrumentation - notify that the image content (UIImage) has been set on the native view.
|
|
*/
|
|
- (void)trackURLImageContentDidSetForRequest:(RCTImageURLLoaderRequest *)loaderRequest;
|
|
|
|
/**
|
|
* Image instrumentation - start tracking the on-screen visibility of the native image view.
|
|
*/
|
|
- (void)trackURLImageVisibilityForRequest:(RCTImageURLLoaderRequest *)loaderRequest imageView:(UIView *)imageView;
|
|
|
|
/**
|
|
* Image instrumentation - notify that the native image view was destroyed.
|
|
*/
|
|
- (void)trackURLImageDidDestroy:(RCTImageURLLoaderRequest *)loaderRequest;
|
|
|
|
@end
|