Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49184 D65645985 shipped a refactor to `Animated`, so that it would use a custom `useAnimatedPropsMemo` instead of `useMemo`. This significantly improved update performance by no longer invalidating the `AnimatedProps` on effectively every update to `Animated` components. However, this was measured to increase memory usage. After a few experiments, we identified that use of the in-band state update was responsible for the memory regression. While this requires further root cause investigation, this diff attempts to mitigate the memory regression. This diff introduces a feature flag that enables an implementation that minimizes duplicated work, such as unnecessarily computing `compositeKey` or creating new instances of `AnimatedProps`. In addition, this implementation strives to do so without significantly degrading when an update is interrupted by a concurrent update. Changelog: [General][Changed] - Introduced a feature flag to test an optimization in `Animated` to reduce memory usage. Reviewed By: rickhanlonii Differential Revision: D69135223 fbshipit-source-id: a2699a314625e7570698bc41455b139711cfd7e3
Feature Flags
Feature flags are values that determine the behavior of specific parts of React Native. This directory contains the configuration for those values, and scripts to generate files for different languages to access and customize them.
There are 2 types of feature flags:
- Common: can be accessed from any language and they provide consistent values everywhere.
- JS-only: they can only be accessed and customized from JavaScript.
Definition
The source of truth for the definition of the flags is the file
ReactNativeFeatureFlags.config.js in this directory.
Example contents:
module.exports = {
common: {
enableNativeBehavior: {
description: 'Enable some behavior both in native and in JS.',
defaultValue: false
}
},
jsOnly: {
enableJSBehavior: {
description: 'Enables some behavior in the JS layer.',
defaultValue: false
}
}
};
After any change to these definitions, the code that provides access to them
must be regenerated running this from the react-native
repository:
yarn featureflags --update
Access
You can access the common feature flags from anywhere in your application using
the ReactNativeFeatureFlags interface (available in C++/Objective-C++,
Kotlin/Java and JavaScript). JS-only feature flags can only be accessed from
JavaScript.
Accessing feature flags should be considered fast for all use cases. Feature flags are cached at every layer, which prevents having to go through JNI when accessing the values from Kotlin and through JSI when accessing the values from JavaScript.
C++ / Objective-C
#include <react/featureflags/ReactNativeFeatureFlags.h>
if (ReactNativeFeatureFlags::enableNativeBehavior()) {
// do something
}
Kotlin
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
fun someMethod() {
if (ReactNativeFeatureFlags.enableNativeBehavior()) {
// do something
}
}
JavaScript
import * as ReactNativeFeatureFlags from 'react-native/src/private/featureflags/ReactNativeFeatureFlags';
if (ReactNativeFeatureFlags.enableNativeBehavior()) {
// Native flag
}
if (ReactNativeFeatureFlags.enableJSBehavior()) {
// JS-only flag
}
Customization
Feature flags provide the default values defined in the configuration unless overrides are applied at the application level. Overrides for common feature flags can only be defined in native, while overrides for JS-ony flags can only be defined in JavaScript.
Overrides must be applied before any of the available feature flags has been accessed. This prevents having inconsistent behavior during the lifecycle of the application.
C++/Objective-C
#include <react/featureflags/ReactNativeFeatureFlags.h>
#include <react/featureflags/ReactNativeFeatureFlagsDefaults.h>
class CustomReactNativeFeatureFlags : public ReactNativeFeatureFlagsDefaults {
public:
CustomReactNativeFeatureFlags();
bool enableNativeBehavior() override {
return true;
}
}
ReactNativeFeatureFlags::override(std::make_unique<CustomReactNativeFeatureFlags>());
Kotlin
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsDefaults
fun overrideFeatureFlags() {
ReactNativeFeatureFlags.override(object : ReactNativeFeatureFlagsDefaults() {
override fun useMicrotasks(): Boolean = true
})
}
JavaScript
import * as ReactNativeFeatureFlags from 'react-native/src/private/featureflags/ReactNativeFeatureFlags';
ReactNativeFeatureFlags.override({
enableJSBehavior: () => true,
});
Architecture
The architecture of this feature flags system can be described as follows:
- A shared C++ core, where we provide access to the flags and allow customizations.
- A Kotlin/Java interface that allows accessing and customizing the values in the C++ core (via JNI).
- A JavaScript interface that allows accessing the common values (via a native module) and accessing and customizing the JS-only values.
This image has an embedded Excalidraw diagram, so you can upload it there if you need to make further modifications.
