react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Valentin Shergin 5db27077cb Fixed a race in RCTDevSettings

Summary:
The diff moves an invocation of `_synchronizeAllSettings` from the constructor to `setBridge`. The side-effects of `_synchronizeAllSettings` rely on a bridge not being nil, so we need to ensure that the bridge is assigned to the instance before calling `_synchronizeAllSettings`.
Before the fix, enabling JavaScript debugger caused a stale and opening many copies of a debugger in Chrome.

Changelog: [Internal] Fixed race and possible stale in RCTDevSettings

Reviewed By: RSNara

Differential Revision: D18379596

fbshipit-source-id: 9f64b9bc5426720948113de61bc9ccc8c39193b4

2019-11-07 14:20:18 -08:00

Base

Ensure RCTDisplayLink and RCTTurboModuleManager are cleaned up properly [3/N]

2019-11-06 14:20:56 -08:00

CoreModules

Fixed a race in RCTDevSettings

2019-11-07 14:20:18 -08:00

CxxBridge

Re-implement reload reason [7/n]

2019-10-30 12:23:25 -07:00

CxxModule

Replace folly::make_unique with std::make_unique (#26730 )