mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Kudo Chien
f97c6a5b49
Summary: `use_frameworks!` is broken again in react-native 0.69 because React-bridging. in the `use_frameworks!` mode, header structures are flattened, so `#include <react/bridging/CallbackWrapper.h>` is not reachable to the header. to somehow workaround the issue without touch React-bridging imports, the pr do these things: - use `header_mappings_dir` to keep `react/bridging` header structure - because the header structure is not default framework header structure, explicitly `HEADER_SEARCH_PATHS` is necessary. - forward declare `CallbackWrapper` and use it internally in ReactCommon. so that we don't need to add `HEADER_SEARCH_PATHS` for React-bridging to every pods depending on `ReactCommon/turbomodule/core`, e.g. React-RCTSettings.podspec. ## Changelog [iOS] [Fixed] - Fix use_frameworks! for 0.69 Pull Request resolved: https://github.com/facebook/react-native/pull/34011 Test Plan: ```sh $ npx react-native init RN069 --version next # add `use_frameworks!` to ios/Podsfile # comment out use_flipper!() in ios/Podfile # patch node_modules/react-native with these changes $ yarn ios ``` Reviewed By: cortinico, cipolleschi Differential Revision: D37169699 Pulled By: dmitryrykun fbshipit-source-id: 309c55f1c611a2fc3902a83e8af814daaf2af6a0
69 lines
3.1 KiB
Ruby
69 lines
3.1 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||
#
|
||
# This source code is licensed under the MIT license found in the
|
||
# LICENSE file in the root directory of this source tree.
|
||
|
||
require "json"
|
||
|
||
package = JSON.parse(File.read(File.join(__dir__, "..", "package.json")))
|
||
version = package['version']
|
||
|
||
source = { :git => 'https://github.com/facebook/react-native.git' }
|
||
if version == '1000.0.0'
|
||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||
else
|
||
source[:tag] = "v#{version}"
|
||
end
|
||
|
||
folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'
|
||
folly_version = '2021.06.28.00-v2'
|
||
boost_compiler_flags = '-Wno-documentation'
|
||
|
||
Pod::Spec.new do |s|
|
||
s.name = "ReactCommon"
|
||
s.module_name = "ReactCommon"
|
||
s.version = version
|
||
s.summary = "-" # TODO
|
||
s.homepage = "https://reactnative.dev/"
|
||
s.license = package["license"]
|
||
s.author = "Facebook, Inc. and its affiliates"
|
||
s.platforms = { :ios => "12.4" }
|
||
s.source = source
|
||
s.header_dir = "ReactCommon" # Use global header_dir for all subspecs for use_frameworks! compatibility
|
||
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags
|
||
s.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\" \"$(PODS_ROOT)/RCT-Folly\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/Headers/Private/React-Core\" \"$(PODS_ROOT)/Headers/Private/React-bridging/react/bridging\" \"$(PODS_CONFIGURATION_BUILD_DIR)/React-bridging/react_bridging.framework/Headers\"",
|
||
"USE_HEADERMAP" => "YES",
|
||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17" }
|
||
|
||
# TODO (T48588859): Restructure this target to align with dir structure: "react/nativemodule/..."
|
||
# Note: Update this only when ready to minimize breaking changes.
|
||
s.subspec "turbomodule" do |ss|
|
||
ss.dependency "React-bridging", version
|
||
ss.dependency "React-callinvoker", version
|
||
ss.dependency "React-perflogger", version
|
||
ss.dependency "React-Core", version
|
||
ss.dependency "React-cxxreact", version
|
||
ss.dependency "React-jsi", version
|
||
ss.dependency "RCT-Folly", folly_version
|
||
s.dependency "React-logger", version
|
||
ss.dependency "DoubleConversion"
|
||
ss.dependency "glog"
|
||
|
||
ss.subspec "core" do |sss|
|
||
sss.source_files = "react/nativemodule/core/ReactCommon/**/*.{cpp,h}",
|
||
"react/nativemodule/core/platform/ios/**/*.{mm,cpp,h}"
|
||
end
|
||
|
||
s.subspec "react_debug_core" do |sss|
|
||
sss.source_files = "react/debug/*.{cpp,h}"
|
||
end
|
||
|
||
ss.subspec "samples" do |sss|
|
||
sss.source_files = "react/nativemodule/samples/ReactCommon/**/*.{cpp,h}",
|
||
"react/nativemodule/samples/platform/ios/**/*.{mm,cpp,h}"
|
||
sss.dependency "ReactCommon/turbomodule/core", version
|
||
end
|
||
end
|
||
end
|