mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Joshua Gross
3d1afbbda3
Summary: JSI callbacks are only destroyed if the callback is called. If the callback is never called, we're potentially leaking a lot of callbacks. To mitigate this, we add a wrapper object that is owned by the std::function. Whenever the std::function is destroyed, the wrapper is destroyed and it deallocates the callback as well. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D27436402 fbshipit-source-id: d153640d5d7988c7fadaf2cb332ec00dadd0689a
107 lines
2.5 KiB
C++
107 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <cassert>
|
|
#include <string>
|
|
|
|
#include <jsi/jsi.h>
|
|
|
|
#include <ReactCommon/CallInvoker.h>
|
|
#include <ReactCommon/LongLivedObject.h>
|
|
|
|
using namespace facebook;
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
jsi::Object deepCopyJSIObject(jsi::Runtime &rt, const jsi::Object &obj);
|
|
jsi::Array deepCopyJSIArray(jsi::Runtime &rt, const jsi::Array &arr);
|
|
|
|
struct Promise : public LongLivedObject {
|
|
Promise(jsi::Runtime &rt, jsi::Function resolve, jsi::Function reject);
|
|
|
|
void resolve(const jsi::Value &result);
|
|
void reject(const std::string &error);
|
|
|
|
jsi::Runtime &runtime_;
|
|
jsi::Function resolve_;
|
|
jsi::Function reject_;
|
|
};
|
|
|
|
using PromiseSetupFunctionType =
|
|
std::function<void(jsi::Runtime &rt, std::shared_ptr<Promise>)>;
|
|
jsi::Value createPromiseAsJSIValue(
|
|
jsi::Runtime &rt,
|
|
const PromiseSetupFunctionType func);
|
|
|
|
// Helper for passing jsi::Function arg to other methods.
|
|
class CallbackWrapper : public LongLivedObject {
|
|
private:
|
|
CallbackWrapper(
|
|
jsi::Function &&callback,
|
|
jsi::Runtime &runtime,
|
|
std::shared_ptr<CallInvoker> jsInvoker)
|
|
: callback_(std::move(callback)),
|
|
runtime_(runtime),
|
|
jsInvoker_(std::move(jsInvoker)) {}
|
|
|
|
jsi::Function callback_;
|
|
jsi::Runtime &runtime_;
|
|
std::shared_ptr<CallInvoker> jsInvoker_;
|
|
|
|
public:
|
|
static std::weak_ptr<CallbackWrapper> createWeak(
|
|
jsi::Function &&callback,
|
|
jsi::Runtime &runtime,
|
|
std::shared_ptr<CallInvoker> jsInvoker) {
|
|
auto wrapper = std::shared_ptr<CallbackWrapper>(
|
|
new CallbackWrapper(std::move(callback), runtime, jsInvoker));
|
|
LongLivedObjectCollection::get().add(wrapper);
|
|
return wrapper;
|
|
}
|
|
|
|
// Delete the enclosed jsi::Function
|
|
void destroy() {
|
|
allowRelease();
|
|
}
|
|
|
|
jsi::Function &callback() {
|
|
return callback_;
|
|
}
|
|
|
|
jsi::Runtime &runtime() {
|
|
return runtime_;
|
|
}
|
|
|
|
CallInvoker &jsInvoker() {
|
|
return *(jsInvoker_);
|
|
}
|
|
};
|
|
|
|
class RAIICallbackWrapperDestroyer {
|
|
public:
|
|
RAIICallbackWrapperDestroyer(std::weak_ptr<CallbackWrapper> callbackWrapper)
|
|
: callbackWrapper_(callbackWrapper) {}
|
|
|
|
~RAIICallbackWrapperDestroyer() {
|
|
auto strongWrapper = callbackWrapper_.lock();
|
|
if (!strongWrapper) {
|
|
return;
|
|
}
|
|
|
|
strongWrapper->destroy();
|
|
}
|
|
|
|
private:
|
|
std::weak_ptr<CallbackWrapper> callbackWrapper_;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|