mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary:
## Issue
You will run into an exception like:
Animated node with tag (child) [8] does not exist
when attempting to convert an Animated node (or starting a native animation) to native when there are multiple non-style props that have AnimatedValues (this should be a very rare case, unless you have a custom native component, as most animated props are in style).
## Root cause
Due to how __makeNative is recursively called up and down the node graph, in a specific case where multiple AnimatedValues have an AnimatedProps as their child, the "connect" operation will occur before the "create" operation for the AnimatedProps node. For example:
- When a native animation is fired via Animated.timing().start(), __makeNative is called on the AnimatedValue (call this node AnimatedValueA) that is being animated. This results in the following sequence of events:
- AnimatedValueA iterates through its children (in this case, AnimatedProps) and calls child.__makeNative
- AnimatedProps iterates through all props with AnimatedValue values and calls __makeNative on them (call these nodes AnimatedValueB and AnimatedValueC).
- AnimatedValueA.__makeNative is called again, but this time, the call early exits and does not do anything.
- AnimatedValueB.__makeNative is called. This in turn calls AnimatedProps.__makeNative, which early exits (ROOT CAUSE OF BUG).
- connectAnimatedNodes is queued (undesired)
## Fix
Short of completely refactoring of how we handle converting the DAG to native (which we should do at some point - the current implementation is error prone and suboptimal. Tracking in T146991336), for now we can make AnimatedProps.__makeNative behavior consistent with AnimatedTransform and AnimatedStyle by just avoiding the early exit, so that the connectAnimatedNodes calls all occur after all native nodes have been created
Changelog:
[General][Fixed] - Fixed error during native DAG creation when there are multiple AnimatedValue props
Reviewed By: rshest
Differential Revision: D43717819
fbshipit-source-id: 258682300a2be65935646b499591acf41eabc56e
175 lines
4.6 KiB
JavaScript
175 lines
4.6 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
import type {PlatformConfig} from '../AnimatedPlatformConfig';
|
|
|
|
import {findNodeHandle} from '../../ReactNative/RendererProxy';
|
|
import {AnimatedEvent} from '../AnimatedEvent';
|
|
import NativeAnimatedHelper from '../NativeAnimatedHelper';
|
|
import AnimatedNode from './AnimatedNode';
|
|
import AnimatedStyle from './AnimatedStyle';
|
|
import invariant from 'invariant';
|
|
|
|
export default class AnimatedProps extends AnimatedNode {
|
|
_props: Object;
|
|
_animatedView: any;
|
|
_callback: () => void;
|
|
|
|
constructor(props: Object, callback: () => void) {
|
|
super();
|
|
if (props.style) {
|
|
props = {
|
|
...props,
|
|
style: new AnimatedStyle(props.style),
|
|
};
|
|
}
|
|
this._props = props;
|
|
this._callback = callback;
|
|
}
|
|
|
|
__getValue(): Object {
|
|
const props: {[string]: any | ((...args: any) => void)} = {};
|
|
for (const key in this._props) {
|
|
const value = this._props[key];
|
|
if (value instanceof AnimatedNode) {
|
|
props[key] = value.__getValue();
|
|
} else if (value instanceof AnimatedEvent) {
|
|
props[key] = value.__getHandler();
|
|
} else {
|
|
props[key] = value;
|
|
}
|
|
}
|
|
|
|
return props;
|
|
}
|
|
|
|
__getAnimatedValue(): Object {
|
|
const props: {[string]: any} = {};
|
|
for (const key in this._props) {
|
|
const value = this._props[key];
|
|
if (value instanceof AnimatedNode) {
|
|
props[key] = value.__getAnimatedValue();
|
|
}
|
|
}
|
|
return props;
|
|
}
|
|
|
|
__attach(): void {
|
|
for (const key in this._props) {
|
|
const value = this._props[key];
|
|
if (value instanceof AnimatedNode) {
|
|
value.__addChild(this);
|
|
}
|
|
}
|
|
}
|
|
|
|
__detach(): void {
|
|
if (this.__isNative && this._animatedView) {
|
|
this.__disconnectAnimatedView();
|
|
}
|
|
for (const key in this._props) {
|
|
const value = this._props[key];
|
|
if (value instanceof AnimatedNode) {
|
|
value.__removeChild(this);
|
|
}
|
|
}
|
|
super.__detach();
|
|
}
|
|
|
|
update(): void {
|
|
this._callback();
|
|
}
|
|
|
|
__makeNative(platformConfig: ?PlatformConfig): void {
|
|
for (const key in this._props) {
|
|
const value = this._props[key];
|
|
if (value instanceof AnimatedNode) {
|
|
value.__makeNative(platformConfig);
|
|
}
|
|
}
|
|
|
|
if (!this.__isNative) {
|
|
this.__isNative = true;
|
|
|
|
// Since this does not call the super.__makeNative, we need to store the
|
|
// supplied platformConfig here, before calling __connectAnimatedView
|
|
// where it will be needed to traverse the graph of attached values.
|
|
super.__setPlatformConfig(platformConfig);
|
|
|
|
if (this._animatedView) {
|
|
this.__connectAnimatedView();
|
|
}
|
|
}
|
|
}
|
|
|
|
setNativeView(animatedView: any): void {
|
|
if (this._animatedView === animatedView) {
|
|
return;
|
|
}
|
|
this._animatedView = animatedView;
|
|
if (this.__isNative) {
|
|
this.__connectAnimatedView();
|
|
}
|
|
}
|
|
|
|
__connectAnimatedView(): void {
|
|
invariant(this.__isNative, 'Expected node to be marked as "native"');
|
|
const nativeViewTag: ?number = findNodeHandle(this._animatedView);
|
|
invariant(
|
|
nativeViewTag != null,
|
|
'Unable to locate attached view in the native tree',
|
|
);
|
|
NativeAnimatedHelper.API.connectAnimatedNodeToView(
|
|
this.__getNativeTag(),
|
|
nativeViewTag,
|
|
);
|
|
}
|
|
|
|
__disconnectAnimatedView(): void {
|
|
invariant(this.__isNative, 'Expected node to be marked as "native"');
|
|
const nativeViewTag: ?number = findNodeHandle(this._animatedView);
|
|
invariant(
|
|
nativeViewTag != null,
|
|
'Unable to locate attached view in the native tree',
|
|
);
|
|
NativeAnimatedHelper.API.disconnectAnimatedNodeFromView(
|
|
this.__getNativeTag(),
|
|
nativeViewTag,
|
|
);
|
|
}
|
|
|
|
__restoreDefaultValues(): void {
|
|
// When using the native driver, view properties need to be restored to
|
|
// their default values manually since react no longer tracks them. This
|
|
// is needed to handle cases where a prop driven by native animated is removed
|
|
// after having been changed natively by an animation.
|
|
if (this.__isNative) {
|
|
NativeAnimatedHelper.API.restoreDefaultValues(this.__getNativeTag());
|
|
}
|
|
}
|
|
|
|
__getNativeConfig(): Object {
|
|
const propsConfig: {[string]: number} = {};
|
|
for (const propKey in this._props) {
|
|
const value = this._props[propKey];
|
|
if (value instanceof AnimatedNode) {
|
|
value.__makeNative(this.__getPlatformConfig());
|
|
propsConfig[propKey] = value.__getNativeTag();
|
|
}
|
|
}
|
|
return {
|
|
type: 'props',
|
|
props: propsConfig,
|
|
};
|
|
}
|
|
}
|