mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Moti Zilberman
d1a99907cb
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53510 Changelog: [Internal] Electron imposes a [strange undocumented limitation](https://github.com/electron/electron/pull/13039) on the format of command-line arguments, which for some reason only affects Windows. Basically, the command line is truncated after the first argument that looks like a URL. Electron's recommendation for avoiding this is to prefix the argument list with `--`, but I prefer switching to a different arg format (`--x=y` instead of `--x y`) that will prevent us from ever running into this issue. NOTE: I will follow up with a diff to harden arg parsing in our Electron code so that it only accepts the `--x=y` format. Reviewed By: huntie Differential Revision: D81237713 fbshipit-source-id: a255dc63b6486b96d9f7ccf780d1b09bc4ddf7e0