mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrei Shikov
1953f6f02e
Summary: With the `MapBuffer`-based props calculated from C++ props, there's no need to keep `rawProps` around for Android views. This change makes sure that the `rawProps` field is only initialized under the feature flag that is responsible for enabling `MapBuffer` for prop diffing, potentially decreasing memory footprint and speeding up node initialization as JS props don't have to be converted to `folly::dynamic` anymore. For layout animations, props rely on C++ values, so there's no need to update `rawProps` values either. Changelog: [Internal][Android] - Do not init `rawProps` when mapbuffer serialization is used for ViewProps. Reviewed By: mdvacca Differential Revision: D33793044 fbshipit-source-id: 35873b10d3ca8b152b25344ef2c27aff9641846f
103 lines
3.2 KiB
C++
103 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <memory>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
|
|
#include <react/renderer/components/root/RootComponentDescriptor.h>
|
|
#include <react/renderer/components/view/ViewComponentDescriptor.h>
|
|
#include <react/renderer/element/ComponentBuilder.h>
|
|
#include <react/renderer/element/Element.h>
|
|
#include <react/renderer/element/testUtils.h>
|
|
|
|
using namespace facebook::react;
|
|
|
|
TEST(ElementTest, testNormalCases) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto shadowNodeA = std::shared_ptr<RootShadowNode>{};
|
|
auto shadowNodeAA = std::shared_ptr<ViewShadowNode>{};
|
|
auto shadowNodeAB = std::shared_ptr<ViewShadowNode>{};
|
|
auto shadowNodeABA = std::shared_ptr<ViewShadowNode>{};
|
|
|
|
auto propsAA = std::make_shared<ViewShadowNodeProps>();
|
|
propsAA->nativeId = "node AA";
|
|
|
|
// clang-format off
|
|
auto element =
|
|
Element<RootShadowNode>()
|
|
.reference(shadowNodeA)
|
|
.tag(1)
|
|
.props([]() {
|
|
auto props = std::make_shared<RootProps>();
|
|
props->nativeId = "node A";
|
|
return props;
|
|
})
|
|
.finalize([](RootShadowNode &shadowNode){
|
|
shadowNode.sealRecursive();
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(shadowNodeAA)
|
|
.tag(2)
|
|
.props(propsAA),
|
|
Element<ViewShadowNode>()
|
|
.reference(shadowNodeAB)
|
|
.tag(3)
|
|
.props([]() {
|
|
auto props = std::make_shared<ViewShadowNodeProps>();
|
|
props->nativeId = "node AB";
|
|
return props;
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(shadowNodeABA)
|
|
.tag(4)
|
|
.props([]() {
|
|
auto props = std::make_shared<ViewShadowNodeProps>();
|
|
props->nativeId = "node ABA";
|
|
return props;
|
|
})
|
|
})
|
|
});
|
|
// clang-format on
|
|
|
|
auto shadowNode = builder.build(element);
|
|
|
|
EXPECT_EQ(shadowNode, shadowNodeA);
|
|
|
|
// Tags
|
|
EXPECT_EQ(shadowNodeA->getTag(), 1);
|
|
EXPECT_EQ(shadowNodeAA->getTag(), 2);
|
|
EXPECT_EQ(shadowNodeAB->getTag(), 3);
|
|
EXPECT_EQ(shadowNodeABA->getTag(), 4);
|
|
|
|
// Children
|
|
EXPECT_EQ(shadowNodeA->getChildren().size(), 2);
|
|
EXPECT_EQ(shadowNodeAA->getChildren().size(), 0);
|
|
EXPECT_EQ(shadowNodeAB->getChildren().size(), 1);
|
|
EXPECT_EQ(shadowNodeABA->getChildren().size(), 0);
|
|
EXPECT_EQ(
|
|
shadowNodeA->getChildren(),
|
|
(ShadowNode::ListOfShared{shadowNodeAA, shadowNodeAB}));
|
|
EXPECT_EQ(
|
|
shadowNodeAB->getChildren(), (ShadowNode::ListOfShared{shadowNodeABA}));
|
|
|
|
// Props
|
|
EXPECT_EQ(shadowNodeA->getProps()->nativeId, "node A");
|
|
EXPECT_EQ(shadowNodeABA->getProps()->nativeId, "node ABA");
|
|
EXPECT_EQ(shadowNodeAA->getProps(), propsAA);
|
|
|
|
// Finalize
|
|
EXPECT_TRUE(shadowNodeA->getSealed());
|
|
EXPECT_TRUE(shadowNodeAA->getSealed());
|
|
EXPECT_TRUE(shadowNodeAB->getSealed());
|
|
EXPECT_TRUE(shadowNodeABA->getSealed());
|
|
}
|