mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fabrizio Cucci
f2c335ac96
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43511 Changelog: [Internal] This is an attempt to fix [#39783](https://github.com/facebook/react-native/issues/39783). It seems that when `configureBuildForHermes` runs (as part of `yarn android` in `rn-tester`) cmake may not be available and is not installed automatically: * for 3p, even after installing the latest Android Studio, cmake 3.22.1 is not available by default but needs to be installed manually * for Meta employees, same story when looking at the `ANDROID_HOME` set by the `setup_fb4a.sh` in the `.zshrc` file: ``` # added by setup_fb4a.sh export ANDROID_SDK=/opt/android_sdk export ANDROID_NDK_REPOSITORY=/opt/android_ndk export ANDROID_HOME=${ANDROID_SDK} export PATH=${PATH}:${ANDROID_SDK}/emulator:${ANDROID_SDK}/tools:${ANDROID_SDK}/tools/bin:${ANDROID_SDK}/platform-tools ``` This diff introduces an explicit task to install cmake. ### ALTERNATIVE 1 See D54897379. ### ALTERNATIVE 2 Suggested by cortinico: > Create a mini module called :packages:react-native:ReactAndroid:hermes-engine:cmake-downloader which just triggers an empty cmake build via Android SDK Reviewed By: cortinico Differential Revision: D54859484 fbshipit-source-id: f9ecdf78ff408947b1e85e7da4f112c89d3a8c89