mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Moti Zilberman
7b86fa2b79
Summary: Changelog: [General][Fixed] - Improved Flow type inference in Animated `.interpolate()` Improves the ergonomics of `.interpolate()` by allowing Flow to infer the correct type for `outputRange`. This is achieved by adding a new type parameter `OutputT` to `interpolate()` (and `Animated.Interpolation` and `InterpolationConfigType`), which Flow infers as either `number` or `string` based on usage. Admittedly, at the call site, this is not that much safer compared to something like `outputRange: $ReadOnlyArray<number | string>`, but it does document the intent of the API a bit better and provide some downstream type safety. For example, we can now express `Animated.Number` (D35869375) more precisely by excluding string-valued interpolation nodes. Reviewed By: javache Differential Revision: D35869725 fbshipit-source-id: e03ec22e9b3368ee196b392af011062ac99d8bb9
83 lines
2.3 KiB
JavaScript
83 lines
2.3 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const AnimatedInterpolation = require('./AnimatedInterpolation');
|
|
const AnimatedNode = require('./AnimatedNode');
|
|
const AnimatedValue = require('./AnimatedValue');
|
|
const AnimatedWithChildren = require('./AnimatedWithChildren');
|
|
|
|
import type {InterpolationConfigType} from './AnimatedInterpolation';
|
|
import type {PlatformConfig} from '../AnimatedPlatformConfig';
|
|
|
|
class AnimatedDivision extends AnimatedWithChildren {
|
|
_a: AnimatedNode;
|
|
_b: AnimatedNode;
|
|
_warnedAboutDivideByZero: boolean = false;
|
|
|
|
constructor(a: AnimatedNode | number, b: AnimatedNode | number) {
|
|
super();
|
|
if (b === 0 || (b instanceof AnimatedNode && b.__getValue() === 0)) {
|
|
console.error('Detected potential division by zero in AnimatedDivision');
|
|
}
|
|
this._a = typeof a === 'number' ? new AnimatedValue(a) : a;
|
|
this._b = typeof b === 'number' ? new AnimatedValue(b) : b;
|
|
}
|
|
|
|
__makeNative(platformConfig: ?PlatformConfig) {
|
|
this._a.__makeNative(platformConfig);
|
|
this._b.__makeNative(platformConfig);
|
|
super.__makeNative(platformConfig);
|
|
}
|
|
|
|
__getValue(): number {
|
|
const a = this._a.__getValue();
|
|
const b = this._b.__getValue();
|
|
if (b === 0) {
|
|
// Prevent spamming the console/LogBox
|
|
if (!this._warnedAboutDivideByZero) {
|
|
console.error('Detected division by zero in AnimatedDivision');
|
|
this._warnedAboutDivideByZero = true;
|
|
}
|
|
// Passing infinity/NaN to Fabric will cause a native crash
|
|
return 0;
|
|
}
|
|
this._warnedAboutDivideByZero = false;
|
|
return a / b;
|
|
}
|
|
|
|
interpolate<OutputT: number | string>(
|
|
config: InterpolationConfigType<OutputT>,
|
|
): AnimatedInterpolation<OutputT> {
|
|
return new AnimatedInterpolation(this, config);
|
|
}
|
|
|
|
__attach(): void {
|
|
this._a.__addChild(this);
|
|
this._b.__addChild(this);
|
|
}
|
|
|
|
__detach(): void {
|
|
this._a.__removeChild(this);
|
|
this._b.__removeChild(this);
|
|
super.__detach();
|
|
}
|
|
|
|
__getNativeConfig(): any {
|
|
return {
|
|
type: 'division',
|
|
input: [this._a.__getNativeTag(), this._b.__getNativeTag()],
|
|
};
|
|
}
|
|
}
|
|
|
|
module.exports = AnimatedDivision;
|