mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Riccardo Cipolleschi
62c9aaea9b
Summary: The `package_and_publish_release_dryrun` workflow does the same steps that we are actually already doing in the `tests` workflow. Both workflows are triggered when `run_nightly_workflow == false && run_release_workflow == false` so the triggering condition **is the same** The following table highlights and compares the steps performed by the two workflows: | Package_and_publish_release_dryrun | Tests | | --- | --- | | `prepare_package_for_release(version: ‘’, latest: false, dryrun: true)` | | | `prepare_hermes_workspace` | `prepare_hermes_workspace` | | `build_hermesc_linux` | `build_hermesc_linux` | | `build_hermes_macos(flavor: Debug | Release)` | `build_hermes_macos(flavor: Debug | Release)` | | `build_hermesc_windows` | `build_hermesc_windows` | | `build_npm_package (release_type: dry-run)` | `build_npm_package(release_type: dry-run)` | The only missing job in `tests` workflow is `prepare_package_for_release`. This job has the following features: 1. It invokes the `prepare-package-for-release.js` scripts, actually testing it. 2. It doesn’t cache anything, 3. it doesn’t attach any workspace Due to 2 and 3, it means that it does not influence any job that follow it in the pipeline as they won't access any of the results from this job. So, we are adding this job in the Test pipeline, so we exercise the `prepare-package-for-release.js` making sure that it works, and remove the whole `package_and_publish_release_dryrun` wroflow as it will now be completely duplicated ## Changelog: [Internal] - Remove the `package_and_publish_release_dryrun` workflow Pull Request resolved: https://github.com/facebook/react-native/pull/38533 Test Plan: CircleCI stays green Reviewed By: cortinico Differential Revision: D47633526 Pulled By: cipolleschi fbshipit-source-id: 28ea9c5944931b992ad07fdeecf08e1d1a86b775