mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin SherginandFacebook GitHub Bot
1acf334614
Summary:
This fixes https://github.com/facebook/react-native/issues/20666 and https://github.com/facebook/react-native/issues/21918.
This is pretty much the same as 51b3529f6c but implemented for Android.
Now <Text> exposes the actual base-line offset value that allows Yoga to position it properly when `alignItems: baseline` is requested.
## Changelog
[Android][Fixed] - Fixed `alignItems: baseline` for <Text> elements on Android
Pull Request resolved: https://github.com/facebook/react-native/pull/31575
Test Plan:
The same test case that we have for iOS.
Before:
<img width="487" alt="Screen Shot 2021-05-22 at 7 03 18 PM" src="https://user-images.githubusercontent.com/22032/119277516-d62b5100-bbe5-11eb-9141-3abe56e1a476.png">
After:
<img width="487" alt="Screen Shot 2021-05-22 at 7 01 51 PM" src="https://user-images.githubusercontent.com/22032/119277518-d75c7e00-bbe5-11eb-9139-4c6b5fcd9157.png">
Reviewed By: JoshuaGross
Differential Revision: D28631468
Pulled By: yungsters
fbshipit-source-id: 7c259e469d19d8344298319f066b8437dfdedad0
