mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Joshua Gross
ec4833f06d
Summary: BUCK always defines NDEBUG on Android builds. This is a longstanding issue and it's tricky to work around. Previous attempts to fix this within React Native were difficult because disabling NDEBUG caused lots of issues that were difficult to track down. Instead, I am (1) introducing a new RN_DEBUG flag that can be used cross-platform, (2) whenever NDEBUG is *not* enabled, RN_DEBUG will automatically be defined, (3) enables debug-only code to be compiled on Android, (4) enables us to selectively, slowly migrate `assert` to `rn_assert` in a way that doesn't impact non-Android platforms, but allows us to maintain stability of Android debug builds. Actually enabling the RN_DEBUG flag in debug builds is done in FB-internal code. I assume the NDEBUG issue is not a problem when compiling in open-source without BUCK. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D26409355 fbshipit-source-id: 285b8073bba3756834925727bfa28d3c6bc06335
51 lines
1.1 KiB
C
51 lines
1.1 KiB
C
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
// No header guards since it is legitimately possible to include this file more
|
|
// than once with and without RN_DEBUG.
|
|
|
|
// rn_assert allows us to opt-in to specific asserts on Android and test before
|
|
// moving on. When all issues have been found, maybe we can use `UNDEBUG` flag
|
|
// to disable NDEBUG in debug builds on Android.
|
|
|
|
#include "flags.h"
|
|
|
|
#undef rn_assert
|
|
|
|
#ifndef RN_DEBUG
|
|
|
|
#define rn_assert(e) ((void)0)
|
|
|
|
#else // RN_DEBUG
|
|
|
|
#ifdef __ANDROID__
|
|
|
|
#include <android/log.h>
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif // __cplusplus
|
|
void rn_assert_fail(
|
|
const char *func,
|
|
const char *file,
|
|
int line,
|
|
const char *expr);
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif // __cpusplus
|
|
|
|
#define rn_assert(e) \
|
|
((e) ? (void)0 : rn_assert_fail(__func__, __FILE__, __LINE__, #e))
|
|
|
|
#else // __ANDROID__
|
|
|
|
#define rn_assert(e) assert(e)
|
|
|
|
#endif // platforms besides __ANDROID__
|
|
|
|
#endif // NDEBUG
|