mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Ruslan Shestopalyuk 0d3c70b636 Fix race condition in ReadableNativeMap (#36201 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36201

[Changelog][Internal]

Guard call to the C++ ReadableNAtiveMap.importValues with a lock.

Note that all the occurrences in this class (together with importTypes) already were protected by a lock, except of this one, which with the very high chance caused crashes in T145271136.

My corresponding comment from the task,  for justification:
> If callstack to be trusted, the crash happens on the C++ side, in ReadableNativeMap::importValues().
It throws ArrayIndexOutOfBoundsException, which, looking at the code, seems to be only possible due to a corrupted data or race conditions.

> Now, looking at the Java side of ReadableNativeMap, and the particular call site... it's very dodgy, since all other occurrences of calling to native importTypes/importValues are guarded by locks, but the one crashing isn't.

NOTE: A couple of `importKeys()` instances appears to suffer from the same problem as well.

Reviewed By: javache

Differential Revision: D43398416

fbshipit-source-id: 0402de5dc723a2fba7d0247c8ad4aeff150d8340

2023-03-28 10:48:18 +01:00

cmake-utils

Fix variable expansion in ReactNative-application.cmake (#35306 )

2022-11-22 11:16:52 +00:00

external-artifacts

Publish both Hermes Debug and Release inside react-native-artifacts

2022-10-19 09:53:49 -07:00

hermes-engine

Bump CMake to 3.22.1 to properly honor CMAKE_BUILD_TYPE (#35857 )

2023-01-19 09:56:40 +00:00

libs

Upgrade Android support library to version 28 in RN