mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
97a4598bab
Summary: This diff adds more enforcement for consistency of `ShadowNodeMutation`s, including: * `Props` object for newly created or updated view must not be nullptr; * `oldShadowView` must describe the previous state of the view for `Update` instruction; * `ignoreDuplicateCreates` option was removed. I suspect some of the crashes we see in Fabric are caused by a violation of one of these constraints. If one of these fails in debug builds, we will get an early signal. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D24880821 fbshipit-source-id: 8c8a3d8e205ce34f6e0335e8a2b0cf676930c284
60 lines
1.4 KiB
C++
60 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include <react/renderer/core/LayoutMetrics.h>
|
|
#include <react/renderer/core/State.h>
|
|
#include <react/renderer/debug/debugStringConvertibleUtils.h>
|
|
#include <react/renderer/mounting/ShadowView.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
class StubView final {
|
|
public:
|
|
using Shared = std::shared_ptr<StubView>;
|
|
|
|
StubView() = default;
|
|
StubView(StubView const &stubView) = default;
|
|
|
|
operator ShadowView() const;
|
|
|
|
void update(ShadowView const &shadowView);
|
|
|
|
ComponentName componentName;
|
|
ComponentHandle componentHandle;
|
|
Tag tag;
|
|
SharedProps props;
|
|
SharedEventEmitter eventEmitter;
|
|
LayoutMetrics layoutMetrics;
|
|
State::Shared state;
|
|
std::vector<StubView::Shared> children;
|
|
};
|
|
|
|
bool operator==(StubView const &lhs, StubView const &rhs);
|
|
bool operator!=(StubView const &lhs, StubView const &rhs);
|
|
|
|
#if RN_DEBUG_STRING_CONVERTIBLE
|
|
|
|
std::string getDebugName(StubView const &stubView);
|
|
|
|
std::vector<DebugStringConvertibleObject> getDebugProps(
|
|
StubView const &stubView,
|
|
DebugStringConvertibleOptions options);
|
|
std::vector<StubView> getDebugChildren(
|
|
StubView const &stubView,
|
|
DebugStringConvertibleOptions options);
|
|
|
|
#endif
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|