mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
3d166a0a4c
Summary: It is the correct way to deal with the measure function. I believe it can fix the crash we see with TextInput state update. The crash is probably caused by invalid value of `shadowNodeRawPtr` in `YogaLayoutableShadowNode::yogaNodeCloneCallbackConnector`. It's hard to reconstruct the full chain of events but I think it's related: Yoga's dirty flag influences cloning, so the improper setting of this flag can misalign "natural" ShadowNode cloning (influenced by changes in the tree) and YGNode-initiated cloning (triggered by layout process). Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D25937710 fbshipit-source-id: a4e7c9dd8f5e6598fc662f4c6ee8061fd795e20d
45 lines
1.2 KiB
C++
45 lines
1.2 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <react/renderer/components/iostextinput/TextInputShadowNode.h>
|
|
#include <react/renderer/core/ConcreteComponentDescriptor.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/*
|
|
* Descriptor for <TextInput> component.
|
|
*/
|
|
class TextInputComponentDescriptor final
|
|
: public ConcreteComponentDescriptor<TextInputShadowNode> {
|
|
public:
|
|
TextInputComponentDescriptor(ComponentDescriptorParameters const ¶meters)
|
|
: ConcreteComponentDescriptor<TextInputShadowNode>(parameters) {
|
|
textLayoutManager_ =
|
|
std::make_shared<TextLayoutManager const>(contextContainer_);
|
|
}
|
|
|
|
protected:
|
|
void adopt(UnsharedShadowNode shadowNode) const override {
|
|
ConcreteComponentDescriptor::adopt(shadowNode);
|
|
|
|
assert(std::dynamic_pointer_cast<TextInputShadowNode>(shadowNode));
|
|
auto concreteShadowNode =
|
|
std::static_pointer_cast<TextInputShadowNode>(shadowNode);
|
|
|
|
concreteShadowNode->setTextLayoutManager(textLayoutManager_);
|
|
}
|
|
|
|
private:
|
|
TextLayoutManager::Shared textLayoutManager_;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|