mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrew Coates
4d87d8c6b2
Summary: react-native-windows runs with a more strict set of warnings as errors. This fixes a bunch of warnings being hit while compiling core react-native code as part of react-native-windows. In particular warnings about mismatched signed/unsigned comparisons, lossy conversions, and variable names that conflict with names in outer scopes (yoga has a global for `leading` and `trailing` that conflicts with some local variable names) ## Changelog [Internal] [Fixed] - Fix various C++ warnings Pull Request resolved: https://github.com/facebook/react-native/pull/31399 Test Plan: I've run these changes in react-native-windows. -- Shouldn't have any functionality difference. Reviewed By: sammy-SC Differential Revision: D28290188 Pulled By: rozele fbshipit-source-id: 2f7cf87f58d73a3f43510ac888dbcb9ab177d134