Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
e94d3444dcface90bd20234d13143462690ff23c
react-native/Libraries
T
History
michalchudziakandLorenzo Sciandra e94d3444dc Fix behaviour of Header, Footer and Empty List components in VirtualizedList when it's inverted (#24167) 
Summary:
Fixes https://github.com/facebook/react-native/issues/23453
Fixes https://github.com/facebook/react-native/issues/21196

Basically, changes made in https://github.com/facebook/react-native/pull/21496 currently breaks behavior of `<VirtualizedList />`  and any components that are based on it (`<SectionList />, <FlatList />`). This PR solves both issues listed above.

Visual confirmation of the resolved issue:

**Vertical, not inverted, not empty**
![image](https://user-images.githubusercontent.com/7837457/55076839-b005d700-5096-11e9-91de-090934cb0129.png)

**Vertical, not inverted, empty**
![image](https://user-images.githubusercontent.com/7837457/55076971-fb1fea00-5096-11e9-8d73-5a2d86275da8.png)

**Vertical, inverted, not empty**
![image](https://user-images.githubusercontent.com/7837457/55077042-23a7e400-5097-11e9-911f-9dad4d48a578.png)

**Vertical, inverted, empty**
![image](https://user-images.githubusercontent.com/7837457/55079957-87351000-509d-11e9-8f1c-b7134f1f43f9.png)

**Horizontal, not inverted, not empty**
![image](https://user-images.githubusercontent.com/7837457/55077118-44703980-5097-11e9-94e9-e33d4af436ee.png)

**Horizontal, not inverted, empty**
![image](https://user-images.githubusercontent.com/7837457/55077150-52be5580-5097-11e9-9d43-7cb4e983167e.png)

**Horizontal, inverted, not empty**
![image](https://user-images.githubusercontent.com/7837457/55077183-623d9e80-5097-11e9-9e8a-1b2468c7b3a9.png)

**Horizontal, inverted, empty**
![image](https://user-images.githubusercontent.com/7837457/55080033-af247380-509d-11e9-90ae-1ff656d46dd1.png)

[General] [Fixed] - Fixed VirtualizedList, SectionList and FlatList behavior on rendering list headers with inverted prop and zero items
Pull Request resolved: https://github.com/facebook/react-native/pull/24167

Differential Revision: D14642345

Pulled By: cpojer

fbshipit-source-id: b530bbbd57f60e53a976ac5db272ea4b2d2b3e99
2019-03-29 15:20:20 +00:00
..
ActionSheetIOS
Feature/action sheet destructive button indexes (#18254)
2019-01-24 12:29:49 -08:00
Alert
Merge AlertIOS with Alert (#23318)
2019-02-12 07:38:42 -08:00
Animated
Add jest test to ensure consistency between AnimatedMock and AnimatedImplementation
2019-02-06 11:02:33 -08:00
AppState
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
ART
Add CF_RETURNS_NOT_RETAINED annotate for Objective-C method which returns Core Foundation object (#23122)
2019-01-23 04:05:56 -08:00
BatchedBridge
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
Blob
Start using getConstants
2019-02-04 17:46:56 -08:00
BugReporting
Upgrade to Flow v0.88.0
2018-12-11 20:01:00 -08:00
CameraRoll
Fixing T38936345 -Opening creative tools from home or creation flow shows a red screen
2019-01-14 10:50:36 -08:00
Color
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
Components
Pass through track color values for true/false to native component
2019-03-22 18:27:21 +01:00
Core
[0.59.2] Bump version numbers
2019-03-25 22:22:14 +01:00
DeprecatedPropTypes
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
EventEmitter
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
Experimental
Fix SwipeableActionButton styling. (#23113)
2019-01-23 04:10:13 -08:00
fishhook
Merge fishhook.xcodeproj in RCTWebSocket
2017-08-09 07:48:09 -07:00
Geolocation
Location Services: don't reset desiredAccuracy on every update/error (#23209)
2019-01-30 10:23:58 -08:00
Image
Add deprecation notice to ImageStore (#23330)
2019-02-11 01:24:03 -08:00
Inspector
Update xplat/js to 0.92.0
2019-02-01 09:35:42 -08:00
Interaction
Fix no shadow warnings (#22190)
2019-01-01 17:13:15 -08:00
JSInspector
Remove explicit requires of Map and Set
2018-10-19 10:57:24 -07:00
LayoutAnimation
Globally disable LayoutAnimation during Snapshot Tests
2019-01-24 15:24:59 -08:00
Linking
Android: Adding sendIntent on Linking module (#22302)
2018-12-06 21:13:58 -08:00
LinkingIOS
Update RCTLinkingManager.h to explicitly state the 'nullability' of parameters (#20798)
2018-09-21 06:18:39 -07:00
Lists
Fix behaviour of Header, Footer and Empty List components in VirtualizedList when it's inverted (#24167)
2019-03-29 15:20:20 +00:00
Modal
RCTModalHostView (#23030)
2019-01-17 02:41:59 -08:00
NativeAnimation
fix broken animation tests
2018-09-28 09:17:17 -07:00
Network
Fix Warnings in Xcode (#23184)
2019-01-28 03:57:42 -08:00
Performance
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
PermissionsAndroid
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
polyfills
Added groupCollapsed polyfill (#21457)
2019-01-22 07:05:22 -08:00
PushNotificationIOS
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
RCTTest
Add types to RCTSnapshotNativeComponent (#23111)
2019-01-23 02:18:10 -08:00
react-native
Merge AlertIOS with Alert (#23318)
2019-02-12 07:38:42 -08:00
ReactNative
Add more init perf markers
2019-02-11 16:50:40 -08:00
Renderer
React sync for revisions f24a0da...8e25ed2
2019-02-27 21:24:27 +01:00
Sample
RN: Missing Copyright Headers
2018-10-31 01:37:26 -07:00
Settings
Start using getConstants
2019-02-04 17:46:56 -08:00
Share
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
Storage
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
StyleSheet
Remove LayoutStyle, ShadowStyle, TransformStyle in favor of just ViewStyleProp
2019-01-08 18:49:37 -08:00
SurfaceBackedComponent
RCTSurface: Calling start is now required to start the Surface
2018-12-18 12:57:38 -08:00
SurfaceHostingComponent
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
Text
Fix TextInput maxLength when insert characters at begin (#23472)
2019-03-29 15:16:14 +00:00
TurboModule
Only call __turboModuleProxy when it exists
2019-02-04 11:08:10 -08:00
Types
Fix internal flow problems
2018-09-27 14:18:31 -07:00
Utilities
Add Platform module for web target (#23387)
2019-02-12 03:32:29 -08:00
vendor
add prettier check in ci (#23382)
2019-02-11 09:06:43 -08:00
Vibration
Use invariant instead of fbjs/lib/invariant
2018-12-03 00:07:02 -08:00
WebSocket
Fix crash for web socket in some race conditions (#22439)
2019-01-01 17:55:29 -08:00
Wrapper
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
YellowBox
Fix View/Text displayName (#21950)
2018-10-29 12:42:10 -07:00
.npmignore
npmignore: ignore tests and fixtures
2018-02-27 08:42:14 -08:00
Promise.js
Stop using Promise from fbjs
2018-11-26 06:28:24 -08:00
promiseRejectionIsError.js
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
UTFSequence.js
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00