Alin PanaitiuandFacebook Github Bot 28c1c88ef7 Adjust row height by font size in PickerIOS ...

Summary:
- [x] Explain the **motivation** for making this change.
- [x] Provide a **test plan** demonstrating that the code is solid.
- [x] Match the **code formatting** of the rest of the codebase.
- [x] Target the `master` branch, NOT a "stable" branch.

There is a problem where setting a bigger fontSize in PickerItem style
clips the top and bottom of the text.
This solves that problem by computing the row height using the font
size.

Create a PickerIOS component and set a larger font size (e.g. 50). The row height will grow accordingly.

Example with `fontSize=50`: [Screenshot](http://i.imgur.com/YwK5fOc.png)
Closes https://github.com/facebook/react-native/pull/13513

Differential Revision: D5692124

Pulled By: shergin

fbshipit-source-id: 4629403e37ad68cdbc0b17b48ba924a77e133078

2017-08-23 20:30:10 -07:00

..

RCTActivityIndicatorView.h

Fixes ActivityIndicatorIOS doesn't hide initially

2016-06-27 17:13:27 -07:00

RCTActivityIndicatorView.m

Fixes ActivityIndicatorIOS doesn't hide initially

2016-06-27 17:13:27 -07:00

RCTActivityIndicatorViewManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTActivityIndicatorViewManager.m

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTAnimationType.h

[LayoutAnimation] RCTAnimationTypeKeyboard

2015-06-25 09:17:01 -08:00

RCTAutoInsetsProtocol.h

Automatically adjust content inset after view controller did layout subviews

2015-09-04 07:00:21 -08:00

RCTBorderDrawing.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTBorderDrawing.m

Fixed border smearing issue

2016-01-07 12:03:17 -08:00

RCTBorderStyle.h

Add property mapping for borderStyle from JS to RCTView (iOS)

2015-12-01 09:00:28 -08:00

RCTComponent.h

Test building with clang 3.9

2016-08-10 13:13:34 -07:00

RCTComponentData.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTComponentData.m

Nits: [NSNull null] was changed to (id)kCFNull`

2017-07-11 12:31:15 -07:00

RCTConvert+CoreLocation.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTConvert+CoreLocation.m

[MapView] Support for annotation callouts, annotation press, callout presses and pin animation

2015-06-25 09:15:21 -08:00

RCTConvert+Transform.h

Drive any numerical prop via NativeAnimated

2017-01-26 18:28:53 -08:00

RCTConvert+Transform.m

Fixed previously broken support for negative scale (transform style property)

2017-03-24 18:15:42 -07:00

RCTDatePicker.h

Added mechanism for directly mapping JS event handlers to blocks

2015-09-02 06:11:24 -08:00

RCTDatePicker.m

Added mechanism for directly mapping JS event handlers to blocks

2015-09-02 06:11:24 -08:00

RCTDatePickerManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTDatePickerManager.m

Removed exported constants for fixed-size views

2016-04-26 04:21:39 -07:00

RCTFont.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTFont.mm

iOS: Fix font weight resolution

2017-07-24 08:33:04 -07:00

RCTMaskedView.h

MaskedViewIOS -- A way to apply alpha masks to views on iOS

2017-07-11 15:05:57 -07:00

RCTMaskedView.m

MaskedViewIOS -- A way to apply alpha masks to views on iOS

2017-07-11 15:05:57 -07:00

RCTMaskedViewManager.h

MaskedViewIOS -- A way to apply alpha masks to views on iOS

2017-07-11 15:05:57 -07:00

RCTMaskedViewManager.m

MaskedViewIOS -- A way to apply alpha masks to views on iOS

2017-07-11 15:05:57 -07:00

RCTModalHostView.h

Fix for Modal behavior when menu button pressed on Apple TV (Issue #15313)

2017-08-17 15:22:12 -07:00

RCTModalHostView.m

Fix for Modal behavior when menu button pressed on Apple TV (Issue #15313)

2017-08-17 15:22:12 -07:00

RCTModalHostViewController.h

Apple TV support 1: existing Objective C code should compile for tvOS

2016-09-27 06:28:33 -07:00

RCTModalHostViewController.m

Replacing all instances of [UIApplication sharedApplication] wi…

2017-04-01 03:34:41 -07:00

RCTModalHostViewManager.h

iOS presentationStyle Modal Appearance

2017-06-20 19:22:57 -07:00

RCTModalHostViewManager.m

Fix for Modal behavior when menu button pressed on Apple TV (Issue #15313)

2017-08-17 15:22:12 -07:00

RCTNavigator.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTNavigator.m

reverted view clipping changes

2016-11-18 14:43:31 -08:00

RCTNavigatorManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTNavigatorManager.m

RCTNavigatorManager - drop unneeded error callback

2017-08-02 10:23:42 -07:00

RCTNavItem.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTNavItem.m

NavigatorIOS System Icon Support

2016-09-08 17:58:50 -07:00

RCTNavItemManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTNavItemManager.m

NavigatorIOS System Icon Support

2016-09-08 17:58:50 -07:00

RCTPicker.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTPicker.m

Adjust row height by font size in PickerIOS

2017-08-23 20:30:10 -07:00

RCTPickerManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTPickerManager.m

Improve types in RCTFont API

2016-08-05 12:44:21 -07:00

RCTPointerEvents.h

[ReactNative] s/ReactKit/React/g

2015-03-26 02:42:24 -08:00

RCTProgressViewManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTProgressViewManager.m

Apple TV support 1: existing Objective C code should compile for tvOS

2016-09-27 06:28:33 -07:00

RCTRefreshControl.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTRefreshControl.m

Make RCTRefreshControl not dependent on order of setting properties

2017-02-17 15:16:01 -08:00

RCTRefreshControlManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTRefreshControlManager.m

Allow to set refresh control title color

2016-04-16 15:15:25 -07:00

RCTRootShadowView.h

Simplifying mess with RCTRootViewSizeFlexibility

2017-02-19 23:19:47 -08:00

RCTRootShadowView.m

Setting availableSize for RCTRootShadowView on earlier stage

2017-03-08 19:00:14 -08:00

RCTScrollableProtocol.h

Add scrollToEnd to ScrollView and ListView

2017-01-27 10:13:29 -08:00

RCTScrollContentShadowView.h

Better RTL support especially for ScrollView's

2017-02-02 09:58:30 -08:00

RCTScrollContentShadowView.m

Better RTL support especially for ScrollView's

2017-02-02 09:58:30 -08:00

RCTScrollContentViewManager.h

Better RTL support especially for ScrollView's

2017-02-02 09:58:30 -08:00

RCTScrollContentViewManager.m

Better RTL support especially for ScrollView's

2017-02-02 09:58:30 -08:00

RCTScrollView.h

Remove onScrollAnimationEnd

2017-07-24 00:32:17 -07:00

RCTScrollView.m

ScrollView: contentOffset validatation now respects contentInset

2017-08-22 16:41:55 -07:00

RCTScrollViewManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTScrollViewManager.m

add pinchEnabled prop to ScrollView

2017-08-06 23:55:16 -07:00

RCTSegmentedControl.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTSegmentedControl.m

Added lightweight generic annotations

2015-11-03 14:49:30 -08:00

RCTSegmentedControlManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTSegmentedControlManager.m

Removed exported constants for fixed-size views

2016-04-26 04:21:39 -07:00

RCTShadowView.h

Introducing -[RCTShadowView canHaveSubviews]

2017-06-20 17:16:46 -07:00

RCTShadowView.m

Fixed assertion caused by invalid layout of hidden Yoga nodes

2017-06-20 17:16:46 -07:00

RCTShadowView+Hierarchy.h

Support shadowView.rootView

2017-07-14 18:26:04 -07:00

RCTShadowView+Hierarchy.m

Support shadowView.rootView

2017-07-14 18:26:04 -07:00

RCTShadowView+Layout.h

Several layout related helper methods of RCTShadowView was moved to new (+Layout) category.

2017-05-08 11:31:20 -07:00

RCTShadowView+Layout.m

Several layout related helper methods of RCTShadowView was moved to new (+Layout) category.

2017-05-08 11:31:20 -07:00

RCTSlider.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTSlider.m

remove unused includes in fbobjc/Libraries

2017-02-19 18:33:49 -08:00

RCTSliderManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTSliderManager.m

Add option for both min/max track image.

2015-12-21 10:30:39 -08:00

RCTSwitch.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTSwitch.m

[ReactNative] s/ReactKit/React/g

2015-03-26 02:42:24 -08:00

RCTSwitchManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTSwitchManager.m

Added mechanism for directly mapping JS event handlers to blocks

2015-09-02 06:11:24 -08:00

RCTTabBar.h

Enable setting color of text and images on unselected tabs

2016-05-03 05:40:29 -07:00

RCTTabBar.m

Apple TV: RCTTabBar selection controlled by native after render (fix #15081)

2017-08-10 05:36:06 -07:00

RCTTabBarItem.h

Apple TV: RCTTabBar selection controlled by native after render (fix #15081)

2017-08-10 05:36:06 -07:00

RCTTabBarItem.m

Apple TV: RCTTabBar selection controlled by native after render (fix #15081)

2017-08-10 05:36:06 -07:00

RCTTabBarItemManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTTabBarItemManager.m

Apple TV support 4: support for input (tvOS focus engine)

2016-12-19 06:28:40 -08:00

RCTTabBarManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTTabBarManager.m

unselectedItemTintColor property available since iOS10

2016-11-29 12:28:55 -08:00

RCTTextDecorationLineType.h

<Text> module add textDecoration style attributes

2015-07-07 06:15:20 -08:00

RCTTVView.h

Apple TV support 4: support for input (tvOS focus engine)

2016-12-19 06:28:40 -08:00

RCTTVView.m

Fix warnings in React.xcodeproj

2017-03-23 11:36:17 -07:00

RCTView.h

Improve z-index implementation on iOS

2017-05-28 21:45:32 -07:00

RCTView.m

Introducing -[RCTView reactAccessibleView]

2017-06-02 14:19:57 -07:00

RCTViewControllerProtocol.h

[ReactNative] s/ReactKit/React/g

2015-03-26 02:42:24 -08:00

RCTViewManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTViewManager.m

Implement nativeID prop to allow native code to reference react managed views in iOS

2017-06-20 19:01:27 -07:00

RCTWebView.h

Add a injectJavaScript method to the WebView component

2017-01-06 20:29:02 -08:00

RCTWebView.m

Improved window.postMessage implementation

2017-07-28 11:35:25 -07:00

RCTWebViewManager.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTWebViewManager.m

Add a injectJavaScript method to the WebView component

2017-01-06 20:29:02 -08:00

RCTWrapperViewController.h

Move all header imports to "<React/..>"

2016-11-23 07:58:39 -08:00

RCTWrapperViewController.m

Apple TV support 1: existing Objective C code should compile for tvOS

2016-09-27 06:28:33 -07:00

UIView+Private.h

Improve z-index implementation on iOS

2017-05-28 21:45:32 -07:00

UIView+React.h

Implement nativeID prop to allow native code to reference react managed views in iOS

2017-06-20 19:01:27 -07:00

UIView+React.m

Implement nativeID prop to allow native code to reference react managed views in iOS

2017-06-20 19:01:27 -07:00