mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Nicola Corti
1a765b6d08
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38885 We do have several Gradle Properties that are used to configure the build. I've refactored them all and moved them inside the PropertyUtils file: https://github.com/facebook/react-native/blob/main/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PropertyUtils.kt Specifically properties should be 'scoped' under `react.` if public, and `react.internal.` if for internal usage. Property that I cleaned up are: - REACT_NATIVE_MAVEN_LOCAL_REPO becomes react.internal.mavenLocalRepo - REACT_WINDOWS_BASH becomes react.internal.windowsBashPath - GROUP becomes react.internal.publishingGroup I've also added support for scoping for public properties with backward compat (so both the scoped and unscoped properties are accepted): - react.newArchEnabled - react.hermesEnabled - react.nativeArchitectures Changelog: [Android] [Changed] - Cleanup and scope all the Gradle Properties Reviewed By: mdvacca Differential Revision: D48188310 fbshipit-source-id: 1a92d31105270a4c2f80029b7d36bcb33916d0fb