mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
trashcoder
e35ca71bca
Summary: I added the contentType parameter to Blob.slice like it's in the MDN Web docs. This PR fixes https://github.com/facebook/react-native/issues/38058 When i slice a Blob for chunked uploads with react native i lost the content type, e.g. "image/jpeg", so the server doesn't know what kind of file he gets. In the docs of MDN the slice method was described with a third contentType parameter which was missing in Metas implementation. ## Changelog: [GENERAL] [ADDED] added a third parameter "contentType" to method slice of class Blob. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/38078 Test Plan: I tested it with the unit-tests: yarn run test Blob-test.js yarn run v1.22.19 $ jest Blob-test.js PASS packages/react-native/Libraries/Blob/__tests__/Blob-test.js Blob ✓ should create empty blob (5 ms) ✓ should create blob from other blobs and strings ✓ should slice a blob (1 ms) ✓ should slice a blob and sets a contentType ✓ should close a blob (4 ms) My added unit test results "✓ should slice a blob and sets a contentType". Reviewed By: hoxyq Differential Revision: D47057162 Pulled By: blakef fbshipit-source-id: 0931b0b828f81b9b90562ffd51d4111c81034ffc