mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
cd6e2b468d
Summary: This diff reverts a revert of D22456266 (https://github.com/facebook/react-native/commit/0060b5de559cd9c785a2a2a6c66f58088fea4dd2) and fixes the reason why it was reverted. Reverted in D22532594 (https://github.com/facebook/react-native/commit/c0e7e1bd9cf050b4a77a20212603d3468826979c). For reason why it was introduced in the first place, please refer to D22456266 (https://github.com/facebook/react-native/commit/0060b5de559cd9c785a2a2a6c66f58088fea4dd2). Problem: `includeTransform` was not taken into account when calculating offset. I added a unit test covering this specific scenario. Reviewed By: shergin Differential Revision: D22763011 fbshipit-source-id: e7d88fc19608ad1a4c7b5e594a9cc48122a2799b
140 lines
4.7 KiB
C++
140 lines
4.7 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include "TestComponent.h"
|
|
|
|
using namespace facebook::react;
|
|
|
|
/*
|
|
*┌─────────────────────────┐
|
|
*│nodeA_ │
|
|
*│ │
|
|
*│ │
|
|
*│ │
|
|
*│ │
|
|
*│ │
|
|
*│ │
|
|
*│ ┌────────────────┐ │
|
|
*│ │nodeAA_ │ │
|
|
*│ │ │ │
|
|
*│ │ ┌───────┐ │ │
|
|
*│ │ │nodeAA_│ │ │
|
|
*│ │ │ │ │ │
|
|
*│ │ └───────┘ │ │
|
|
*│ └────────────────┘ │
|
|
*└─────────────────────────┘
|
|
*/
|
|
class FindNodeAtPointTest : public ::testing::Test {
|
|
protected:
|
|
FindNodeAtPointTest()
|
|
: eventDispatcher_(std::shared_ptr<EventDispatcher const>()),
|
|
componentDescriptor_(TestComponentDescriptor({eventDispatcher_})) {
|
|
auto traits = TestShadowNode::BaseTraits();
|
|
|
|
auto familyA = std::make_shared<ShadowNodeFamily>(
|
|
ShadowNodeFamilyFragment{
|
|
/* .tag = */ 9,
|
|
/* .surfaceId = */ 1,
|
|
/* .eventEmitter = */ nullptr,
|
|
},
|
|
eventDispatcher_,
|
|
componentDescriptor_);
|
|
|
|
nodeA_ = std::make_shared<TestShadowNode>(
|
|
ShadowNodeFragment{
|
|
/* .props = */ std::make_shared<const TestProps>(),
|
|
/* .children = */ ShadowNode::emptySharedShadowNodeSharedList(),
|
|
},
|
|
familyA,
|
|
traits);
|
|
|
|
auto familyAA = std::make_shared<ShadowNodeFamily>(
|
|
ShadowNodeFamilyFragment{
|
|
/* .tag = */ 10,
|
|
/* .surfaceId = */ 1,
|
|
/* .eventEmitter = */ nullptr,
|
|
},
|
|
eventDispatcher_,
|
|
componentDescriptor_);
|
|
|
|
nodeAA_ = std::make_shared<TestShadowNode>(
|
|
ShadowNodeFragment{
|
|
/* .props = */ std::make_shared<const TestProps>(),
|
|
/* .children = */ ShadowNode::emptySharedShadowNodeSharedList(),
|
|
},
|
|
familyAA,
|
|
traits);
|
|
|
|
auto familyAAA = std::make_shared<ShadowNodeFamily>(
|
|
ShadowNodeFamilyFragment{
|
|
/* .tag = */ 11,
|
|
/* .surfaceId = */ 1,
|
|
/* .eventEmitter = */ nullptr,
|
|
},
|
|
eventDispatcher_,
|
|
componentDescriptor_);
|
|
|
|
nodeAAA_ = std::make_shared<TestShadowNode>(
|
|
ShadowNodeFragment{
|
|
/* .props = */ std::make_shared<const TestProps>(),
|
|
/* .children = */ ShadowNode::emptySharedShadowNodeSharedList(),
|
|
},
|
|
familyAAA,
|
|
traits);
|
|
|
|
nodeA_->appendChild(nodeAA_);
|
|
nodeAA_->appendChild(nodeAAA_);
|
|
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
|
|
layoutMetrics.frame = facebook::react::Rect{
|
|
facebook::react::Point{0, 0}, facebook::react::Size{1000, 1000}};
|
|
nodeA_->setLayoutMetrics(layoutMetrics);
|
|
|
|
layoutMetrics.frame = facebook::react::Rect{
|
|
facebook::react::Point{100, 100}, facebook::react::Size{100, 100}};
|
|
nodeAA_->setLayoutMetrics(layoutMetrics);
|
|
|
|
layoutMetrics.frame = facebook::react::Rect{facebook::react::Point{10, 10},
|
|
facebook::react::Size{10, 10}};
|
|
nodeAAA_->setLayoutMetrics(layoutMetrics);
|
|
}
|
|
|
|
std::shared_ptr<EventDispatcher const> eventDispatcher_;
|
|
std::shared_ptr<TestShadowNode> nodeA_;
|
|
std::shared_ptr<TestShadowNode> nodeAA_;
|
|
std::shared_ptr<TestShadowNode> nodeAAA_;
|
|
TestComponentDescriptor componentDescriptor_;
|
|
};
|
|
|
|
TEST_F(FindNodeAtPointTest, withoutTransform) {
|
|
EXPECT_EQ(
|
|
LayoutableShadowNode::findNodeAtPoint(nodeA_, {115, 115}), nodeAAA_);
|
|
EXPECT_EQ(LayoutableShadowNode::findNodeAtPoint(nodeA_, {105, 105}), nodeAA_);
|
|
EXPECT_EQ(LayoutableShadowNode::findNodeAtPoint(nodeA_, {900, 900}), nodeA_);
|
|
EXPECT_EQ(
|
|
LayoutableShadowNode::findNodeAtPoint(nodeA_, {1001, 1001}), nullptr);
|
|
}
|
|
|
|
TEST_F(FindNodeAtPointTest, viewIsTranslated) {
|
|
nodeA_->_contentOriginOffset = {-100, -100};
|
|
|
|
EXPECT_EQ(
|
|
LayoutableShadowNode::findNodeAtPoint(nodeA_, {15, 15})->getTag(),
|
|
nodeAAA_->getTag());
|
|
EXPECT_EQ(LayoutableShadowNode::findNodeAtPoint(nodeA_, {5, 5}), nodeAA_);
|
|
}
|
|
|
|
TEST_F(FindNodeAtPointTest, viewIsScaled) {
|
|
nodeAAA_->_transform = Transform::Identity() * Transform::Scale(0.5, 0.5, 0);
|
|
|
|
EXPECT_EQ(
|
|
LayoutableShadowNode::findNodeAtPoint(nodeA_, {119, 119})->getTag(),
|
|
nodeAA_->getTag());
|
|
}
|