mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Moti ZilbermanandFacebook GitHub Bot e16b6470e4 Backout D82236159: [RN][debugger-shell] Implement saved window positioning per target (#53816 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/53816

Changelog: [Internal]

D82236159 introduced the first `node_modules` dependency in the Electron part of `react-native/debugger-shell`. This is not currently handled correctly by the build script, so this resulted in an instacrashing binary.

I'm temporarily backing out D82236159 until we have a proper fix for the build script.

Reviewed By: robhogan

Differential Revision: D82632937

fbshipit-source-id: 6c7c182e2a7c89e6ea2761096dcc426dbf2ae5cb

2025-09-19 02:38:00 -07:00

__tests__

Demote electron to devDependency (#53438 )

2025-08-27 02:50:05 -07:00

bin

Revert D82459089: Update React Native DevTools binaries

2025-09-16 05:33:44 -07:00

src

Backout D82236159: [RN][debugger-shell] Implement saved window positioning per target (#53816 )

2025-09-19 02:38:00 -07:00

package.json

Backout D82236159: [RN][debugger-shell] Implement saved window positioning per target (#53816 )

2025-09-19 02:38:00 -07:00

README.md

…

README.md

@react-native/debugger-shell

Experimental Electron-based shell for React Native DevTools. This package is not part of React Native's public API.

Why Electron?

The React Native DevTools frontend is based on Chrome DevTools, which is a web app, but is not particularly portable: it's designed to run in Chromium, and Chromium only. Prior to @react-native/debugger-shell, we would run it in hosted mode in an instance of Chrome or Edge.

Relying on hosted mode presents a variety of UX issues in the debugging workflow, such as the need to ask developers to install a particular browser before they can debug in React Native, and the inability to foreground/reuse existing debugger windows when relaunching the debugger for the same app. In order to address these issues effectively, we fundamentally need to leave the browser sandbox and run the debugger in a shell we can bundle with React Native, and whose behavior we can control.

Electron is a tried-and-tested framework for the specific task of embedding a Chromium browser in a portable, customized shell. As a rule we'll hold a high bar for performance and reliability, and we'll only add features to the shell if they are strictly necessary to complement the DevTools frontend's built-in capabilities.