mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
2669118fc8
Summary: Changelog: [internal] Previous implementation of coalescing would only look at the last element in `eventQueue_` and if it was the same type and target, it would coalesce the two together. This was problem when user would scroll in UIScrollView, this triggers onTouchMove and onScroll events at high rates and prevents coalescing of them. This changes changes the behaviour to search the `eventQueue_` backwards for an event of the same type and target. If one if found, it is moved into its place. If even of another type is found before for the same target, the event is pushed back onto the queue. Reviewed By: JoshuaGross Differential Revision: D24992941 fbshipit-source-id: fc1eae4ecd100af6202346674778b0634ed7a15b
71 lines
1.9 KiB
C++
71 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "BatchedEventQueue.h"
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
BatchedEventQueue::BatchedEventQueue(
|
|
EventPipe eventPipe,
|
|
StatePipe statePipe,
|
|
std::unique_ptr<EventBeat> eventBeat,
|
|
bool enableV2EventCoalescing)
|
|
: EventQueue(eventPipe, statePipe, std::move(eventBeat)),
|
|
enableV2EventCoalescing_(enableV2EventCoalescing) {}
|
|
|
|
void BatchedEventQueue::onEnqueue() const {
|
|
EventQueue::onEnqueue();
|
|
|
|
eventBeat_->request();
|
|
}
|
|
|
|
void BatchedEventQueue::enqueueUniqueEvent(RawEvent const &rawEvent) const {
|
|
{
|
|
std::lock_guard<std::mutex> lock(queueMutex_);
|
|
|
|
if (enableV2EventCoalescing_) {
|
|
auto repeatedEvent = eventQueue_.rend();
|
|
|
|
for (auto it = eventQueue_.rbegin(); it != eventQueue_.rend(); ++it) {
|
|
if (it->type == rawEvent.type &&
|
|
it->eventTarget == rawEvent.eventTarget) {
|
|
repeatedEvent = it;
|
|
break;
|
|
} else if (it->eventTarget == rawEvent.eventTarget) {
|
|
// It is necessary to maintain order of different event types
|
|
// for the same target. If the same target has event types A1, B1
|
|
// in the event queue and event A2 occurs. A1 has to stay in the
|
|
// queue.
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (repeatedEvent == eventQueue_.rend()) {
|
|
eventQueue_.push_back(rawEvent);
|
|
} else {
|
|
*repeatedEvent = std::move(rawEvent);
|
|
}
|
|
} else {
|
|
if (!eventQueue_.empty()) {
|
|
auto const position = eventQueue_.back();
|
|
if (position.type == rawEvent.type &&
|
|
position.eventTarget == rawEvent.eventTarget) {
|
|
eventQueue_.pop_back();
|
|
}
|
|
}
|
|
|
|
eventQueue_.push_back(rawEvent);
|
|
}
|
|
}
|
|
|
|
onEnqueue();
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|