react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Samuel Susla df17ebfcfa Back out "[react-native][PR] [iOS] Add convert compatible of NSString for bridge message data"

Summary:
Original commit changeset: 4849a8e94141

# Problem:
This diff caused https://github.com/facebook/react-native/issues/25339.
It was converting non string values to strings whenever the conversion was available.

The original problem that this diff was trying to solve is described here -> https://twitter.com/estevao_lucas/status/1117572702083190785?s=215

# Solution introduced by this diff
This diff introduced a conversion. So for any value that was meant to be string but wasn't we would attempt to convert it. Which is not always wanted.

# Solution for problem in the twitter
I think we should improve the error message if incorrect type is being passed as a prop. However this isn't a problem if views are Flow typed.

Reviewed By: cpojer

Differential Revision: D15964298

fbshipit-source-id: 3d027a378561b87e7a9e89fc5e39dc6f359d8d22

2019-06-24 07:13:46 -07:00

Base

Back out "[react-native][PR] [iOS] Add convert compatible of NSString for bridge message data"

2019-06-24 07:13:46 -07:00

CxxBridge

TM iOS: Prevent module cache invalidation race

2019-06-21 15:54:01 -07:00

CxxModule

Silence Xcode warning (#23880 )

2019-03-12 22:08:21 -07:00

CxxUtils

Update copyright headers to yearless format