mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
ffc90c7f92
Summary: Changelog: Fix [TypeError: Network request failed] on file upload # Problem In https://github.com/facebook/react-native/commit/31980094107ed37f8de70972dbcc319cc9a26339 I made method `loadImageForURL` blocking and nil returning since it was no longer cancellable. However inside `[RCTNetworkTask validateRequestToken]` was a logic counting on request token being non nil. This diff removes this check and adds `nullable` to `[RCTImageURLLoader loadImageForURL]` making it explicit. Reviewed By: PeteTheHeat Differential Revision: D22767174 fbshipit-source-id: 04d5562e381912233b9c14e8156cbf145288f063
72 lines
2.0 KiB
Plaintext
72 lines
2.0 KiB
Plaintext
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <React/RCTLocalAssetImageLoader.h>
|
|
|
|
#import <atomic>
|
|
#import <memory>
|
|
|
|
#import <React/RCTUtils.h>
|
|
#import <ReactCommon/RCTTurboModule.h>
|
|
|
|
#import "RCTImagePlugins.h"
|
|
|
|
@interface RCTLocalAssetImageLoader() <RCTTurboModule>
|
|
@end
|
|
|
|
@implementation RCTLocalAssetImageLoader
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (BOOL)canLoadImageURL:(NSURL *)requestURL
|
|
{
|
|
return RCTIsLocalAssetURL(requestURL);
|
|
}
|
|
|
|
- (BOOL)requiresScheduling
|
|
{
|
|
// Don't schedule this loader on the URL queue so we can load the
|
|
// local assets synchronously to avoid flickers.
|
|
return NO;
|
|
}
|
|
|
|
- (BOOL)shouldCacheLoadedImages
|
|
{
|
|
// UIImage imageNamed handles the caching automatically so we don't want
|
|
// to add it to the image cache.
|
|
return NO;
|
|
}
|
|
|
|
- (nullable RCTImageLoaderCancellationBlock)loadImageForURL:(NSURL *)imageURL
|
|
size:(CGSize)size
|
|
scale:(CGFloat)scale
|
|
resizeMode:(RCTResizeMode)resizeMode
|
|
progressHandler:(RCTImageLoaderProgressBlock)progressHandler
|
|
partialLoadHandler:(RCTImageLoaderPartialLoadBlock)partialLoadHandler
|
|
completionHandler:(RCTImageLoaderCompletionBlock)completionHandler
|
|
{
|
|
UIImage *image = RCTImageFromLocalAssetURL(imageURL);
|
|
if (image) {
|
|
if (progressHandler) {
|
|
progressHandler(1, 1);
|
|
}
|
|
completionHandler(nil, image);
|
|
} else {
|
|
NSString *message = [NSString stringWithFormat:@"Could not find image %@", imageURL];
|
|
RCTLogWarn(@"%@", message);
|
|
completionHandler(RCTErrorWithMessage(message), nil);
|
|
}
|
|
|
|
return nil;
|
|
}
|
|
|
|
@end
|
|
|
|
Class RCTLocalAssetImageLoaderCls(void) {
|
|
return RCTLocalAssetImageLoader.class;
|
|
}
|