mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42685 This diff fixes the TextInput-textStyles-e2e test. The rootcause of this issue is that we were updating the lineHeight of ReactEditText (AppCompatEditText) when lineHeight is set as a prop from React. This is a problem, because one one side lineHeight is managed by React Native (setting styles in the spannables) and on the other side we ar calling setLineHeight on AppCompatEditText, which breaks the rendering. We should only manage lineHeight using RN styles, that's why I'm removing call to super.setLineHeight() Changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D53142429 fbshipit-source-id: cedf803171a490afa67252e9e7f83749502326e6