Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
dd6d57eea107f1b89ff89cc439dcbe73093e5d17
react-native/packages/rn-tester/NativeCxxModuleExample
T
History
Pieter De Baets dd6d57eea1 Fix cxx codegen handling of optional return types (#36581) 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36581

Found that the current codegen did not properly handle a return type of `?bool` because the branch of `constexpr (is_optional_v<T>)` assumed that T was always a JSI value that needed conversion, and `supportsToJs<bool, bool>` is false.

Changelog: [General][Fixed] Issue with TurboModule C++ codegen with optional return types

Reviewed By: christophpurrer

Differential Revision: D44302352

fbshipit-source-id: 0863de06da4e5e3c18f8a1ced7179d76d8e87b99
2023-03-23 03:10:25 -07:00
..
CMakeLists.txt
react-native code-gen > Add a C++ only TurboModule example (for Android/iOS/macOS/Windows) (#35138)
2022-11-09 10:48:49 -08:00
NativeCxxModuleExample.cpp
Fix cxx codegen handling of optional return types (#36581)
2023-03-23 03:10:25 -07:00
NativeCxxModuleExample.h
Fix cxx codegen handling of optional return types (#36581)
2023-03-23 03:10:25 -07:00
NativeCxxModuleExample.js
Fix cxx codegen handling of optional return types (#36581)
2023-03-23 03:10:25 -07:00
NativeCxxModuleExample.podspec
react-native code-gen > Add a C++ only TurboModule example (for Android/iOS/macOS/Windows) (#35138)
2022-11-09 10:48:49 -08:00