mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ruslan Lesiutin
dd240edd6d
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49007 # Changelog: [Internal] Before sending `Tracing.start`, CDT will also send `Debugger.disable`. You don't want to hit your breakpoints when you are profiling an appplication, this is by design. We won't just delegate this to Hermes to handle. We will explicitly check that this condition is satisfied on React Native side. This is done to avoid regression in case the implementation details will change on CDT side. Later in D68414421, we will also check that samples JavaScript stack don't contain debugger frames. This is necessary to distinguish garbage collector frames from debugger frames, which share the same type in Hermes VM - "Suspend". We need garbage collector frames. If debugger frame was found we would throw an error, because this is unexpected after Debugger domain was disabled. Right now Hermes is not disabling local VM Debugger on `Debugger.disable` method - this is a known bug, which I am addressing in a stack from D68772900. Reviewed By: huntie Differential Revision: D68776863 fbshipit-source-id: 4346ac5eb850578265a179b5fd687539ae7d15bc