mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
3a5eedffff
Summary:
Changelog: [internal]
There are two exceptions inside `TelemetryController::pullTransaction`:
- Empty Optional cannot be unwrapped
- mutex lock failed: Invalid argument
By marking this method `noexcept`, stack trace is lost and it makes it more difficult to track down the issue.
What does compiler do if a method is marked `noexcept`?
```
void f() noexcept {
try {
// do work
}
catch (...) {
std::terminate(); // This is the std::terminate() we are seeing in stack traces.
}
}
```
Removing noexcept specifier might give us more information about the exception.
Reviewed By: JoshuaGross
Differential Revision: D24477861
fbshipit-source-id: 80f26e9ab160a5330c2848b89a01d60bfc0a4611
58 lines
1.5 KiB
C++
58 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <functional>
|
|
#include <mutex>
|
|
|
|
#include <react/renderer/mounting/MountingTransaction.h>
|
|
#include <react/renderer/mounting/MountingTransactionMetadata.h>
|
|
#include <react/renderer/mounting/TransactionTelemetry.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
class MountingCoordinator;
|
|
|
|
/*
|
|
* Provides convenient tools for aggregating and accessing telemetry data
|
|
* associated with running Surface.
|
|
*/
|
|
class TelemetryController final {
|
|
friend class MountingCoordinator;
|
|
|
|
/*
|
|
* To be used by `MountingCoordinator`.
|
|
*/
|
|
TelemetryController(MountingCoordinator const &mountingCoordinator) noexcept;
|
|
|
|
/*
|
|
* Not copyable.
|
|
*/
|
|
TelemetryController(TelemetryController const &other) noexcept = delete;
|
|
TelemetryController &operator=(TelemetryController const &other) noexcept =
|
|
delete;
|
|
|
|
public:
|
|
/*
|
|
* Calls `MountingCoordinator::pullTransaction()` and aggregates telemetry.
|
|
*/
|
|
bool pullTransaction(
|
|
std::function<void(MountingTransactionMetadata metadata)> willMount,
|
|
std::function<void(ShadowViewMutationList const &mutations)> doMount,
|
|
std::function<void(MountingTransactionMetadata metadata)> didMount) const;
|
|
|
|
private:
|
|
MountingCoordinator const &mountingCoordinator_;
|
|
mutable SurfaceTelemetry compoundTelemetry_{};
|
|
mutable std::mutex mutex_;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|