mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
TMaszkoandFacebook GitHub Bot
d92284216f
Summary: After animation has been finished using Native driver there is no final value passed from the native to JS side. This causes a bug from https://github.com/facebook/react-native/issues/28114. This PR solves this problem in the same way as `react-native-reanimated` library. When detaching it is calling native side to get the last value from Animated node and stores it on the JS side. Preserving animated value even if animation was using `useNativeDriver: true` Fixes https://github.com/facebook/react-native/issues/28114 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Fixed] - Save native Animated node value on JS side in detach phase Pull Request resolved: https://github.com/facebook/react-native/pull/28841 Test Plan: Unit tests for added getValue method passed. Green CI Reviewed By: mdvacca Differential Revision: D22211499 Pulled By: JoshuaGross fbshipit-source-id: 9a3a98a9f9a8536fe2c8764f667cdabe1f6ba82a
69 lines
2.3 KiB
JavaScript
69 lines
2.3 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
import type {TurboModule} from '../../TurboModule/RCTExport';
|
|
import * as TurboModuleRegistry from '../../TurboModule/TurboModuleRegistry';
|
|
|
|
type EndResult = {finished: boolean, ...};
|
|
type EndCallback = (result: EndResult) => void;
|
|
type SaveValueCallback = (value: number) => void;
|
|
|
|
export type EventMapping = {|
|
|
nativeEventPath: Array<string>,
|
|
animatedValueTag: ?number,
|
|
|};
|
|
|
|
// The config has different keys depending on the type of the Node
|
|
// TODO(T54896888): Make these types strict
|
|
export type AnimatedNodeConfig = Object;
|
|
export type AnimatingNodeConfig = Object;
|
|
|
|
export interface Spec extends TurboModule {
|
|
+createAnimatedNode: (tag: number, config: AnimatedNodeConfig) => void;
|
|
+getValue: (tag: number, saveValueCallback: SaveValueCallback) => void;
|
|
+startListeningToAnimatedNodeValue: (tag: number) => void;
|
|
+stopListeningToAnimatedNodeValue: (tag: number) => void;
|
|
+connectAnimatedNodes: (parentTag: number, childTag: number) => void;
|
|
+disconnectAnimatedNodes: (parentTag: number, childTag: number) => void;
|
|
+startAnimatingNode: (
|
|
animationId: number,
|
|
nodeTag: number,
|
|
config: AnimatingNodeConfig,
|
|
endCallback: EndCallback,
|
|
) => void;
|
|
+stopAnimation: (animationId: number) => void;
|
|
+setAnimatedNodeValue: (nodeTag: number, value: number) => void;
|
|
+setAnimatedNodeOffset: (nodeTag: number, offset: number) => void;
|
|
+flattenAnimatedNodeOffset: (nodeTag: number) => void;
|
|
+extractAnimatedNodeOffset: (nodeTag: number) => void;
|
|
+connectAnimatedNodeToView: (nodeTag: number, viewTag: number) => void;
|
|
+disconnectAnimatedNodeFromView: (nodeTag: number, viewTag: number) => void;
|
|
+restoreDefaultValues: (nodeTag: number) => void;
|
|
+dropAnimatedNode: (tag: number) => void;
|
|
+addAnimatedEventToView: (
|
|
viewTag: number,
|
|
eventName: string,
|
|
eventMapping: EventMapping,
|
|
) => void;
|
|
+removeAnimatedEventFromView: (
|
|
viewTag: number,
|
|
eventName: string,
|
|
animatedNodeTag: number,
|
|
) => void;
|
|
|
|
// Events
|
|
+addListener: (eventName: string) => void;
|
|
+removeListeners: (count: number) => void;
|
|
}
|
|
|
|
export default (TurboModuleRegistry.get<Spec>('NativeAnimatedModule'): ?Spec);
|