Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
d30bd1bb21cda404d7a2e2c502bd1027190fec0e
react-native/Libraries
T
History
mym0404 a8166bd75b Fix crash by conditional value of aspectRatio style value (#35858) (#35859) 
Summary:
fix https://github.com/facebook/react-native/issues/35858

## Changelog

1. Handle not `number` | `string` value passed to `aspectRatio`
2. Add some tests

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[GENERAL] [FIXED] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

Pull Request resolved: https://github.com/facebook/react-native/pull/35859

Test Plan:
## Sample
[Sample Repository](https://github.com/mym0404/rn-aspect-ratio-crash-sample)

Video

![1](https://user-images.githubusercontent.com/33388801/212956921-94b21cda-d841-4588-a05a-d604a82e204c.gif)

Reviewed By: necolas

Differential Revision: D42575942

Pulled By: NickGerleman

fbshipit-source-id: 2f7f46e6e3af85146e4042057477cb6d63b3b279
2023-01-25 17:15:19 -08:00
..
__flowtests__
RN: Sort Imports via ESLint
2022-09-30 14:28:48 -07:00
ActionSheetIOS
ESM processColor
2023-01-03 18:09:06 -08:00
Alert
Adding AlertOptions to ts Alert.prompt function (#35957)
2023-01-25 02:14:45 -08:00
Animated
Upgrade to Flow 0.198.1
2023-01-23 07:38:48 -08:00
AppDelegate
feat: add initialProps property to RCTAppDelegate (#35848)
2023-01-18 06:42:39 -08:00
AppState
RN: Sort Imports via ESLint
2022-09-30 14:28:48 -07:00
BatchedBridge
Upgrade to Flow 0.198.1
2023-01-23 07:38:48 -08:00
Blob
Upgrade to Flow 0.198.1
2023-01-23 07:38:48 -08:00
BugReporting
Codemod cycle annotations for xplat/js
2022-11-01 17:13:27 -07:00
Components
Add maintainVisibleContentPosition support on Android (#35049)
2023-01-23 12:00:05 -08:00
Core
setUpPerformance not to redirect to WebPerformance before the API is public (#35901)
2023-01-19 10:08:32 -08:00
DevToolsSettings
Add iOS + Android support for getting/setting reload-and-profile-related settings
2022-12-05 22:07:30 -08:00
EventEmitter
RN: Sort Imports via ESLint
2022-09-30 14:28:48 -07:00
Events
remove return type from constructor (#35466)
2022-11-24 18:26:36 -08:00
FBLazyVector
Remove fb_apple_library export from rn_defs
2022-11-17 09:56:30 -08:00
HeapCapture
RN: Sort Imports via ESLint
2022-09-30 14:28:48 -07:00
Image
remove unused type imports 1/1
2023-01-18 08:21:49 -08:00
Inspector
ESM Dimensions
2023-01-03 18:09:06 -08:00
Interaction
Update Jest type definitions to v29
2023-01-18 10:52:29 -08:00
JSInspector
RN: Sort Imports via ESLint
2022-09-30 14:28:48 -07:00
LayoutAnimation
RN: Sort Imports via ESLint
2022-09-30 14:28:48 -07:00
Linking
Do not use InteractionManager to wait for Activity (#35289)
2022-11-14 03:38:52 -08:00
LinkingIOS
Update .podspec license information (#35245)
2022-11-07 09:52:52 -08:00
Lists
Fix invariant violation when nesting VirtualizedList inside ListEmptyComponent (#35875)
2023-01-19 05:13:50 -08:00
LogBox
ESM LogBox
2023-01-03 18:09:06 -08:00
Modal
Update reference to statusBarTranslucent in Modal comment
2022-12-09 02:30:09 -08:00
NativeAnimation
Support colors for AnimatedInterpolation on iOS
2022-12-05 08:24:54 -08:00
NativeComponent
feat: Add logical border radius implementation (#35572)
2023-01-06 06:00:03 -08:00
NativeModules/specs
Scaffolding for the PerformanceObserver TurboModule (C++ side) (#35226)
2022-11-08 10:01:21 -08:00
Network
ESM RCTNetworking
2023-01-03 18:09:06 -08:00
NewAppScreen
RN: Sort Imports via ESLint
2022-09-30 14:28:48 -07:00
Performance
Exclude PerformanceObserver from flow/haste
2022-11-03 07:14:41 -07:00
PermissionsAndroid
Rename POST_NOTIFICATION to POST_NOTIFICATIONS (#35533)
2022-12-09 12:56:07 -08:00
Pressability
Expose setLongPressDeactivationDistance as class method
2022-12-09 12:58:02 -08:00
PushNotificationIOS
Add missing types to PushNotificationIOS
2022-12-15 09:54:03 -08:00
RCTRequired
fix missing imports and set disable_infer_precompiled_header]
2022-12-04 13:30:16 -08:00
ReactNative
react-native | remove unused internal feature flag
2023-01-23 10:37:36 -08:00
ReactPrivate
Enable LTI in react-native
2022-12-06 19:34:14 -08:00
Reliability
Update copyright headers from Facebook to Meta
2021-12-30 15:11:21 -08:00
Renderer
Enable LTI in react-native
2022-12-06 19:34:14 -08:00
Settings
Update .podspec license information (#35245)
2022-11-07 09:52:52 -08:00
Share
ESM processColor
2023-01-03 18:09:06 -08:00
StyleSheet
Fix crash by conditional value of aspectRatio style value (#35858) (#35859)
2023-01-25 17:15:19 -08:00
SurfaceBackedComponent
Remove clang-format opt-out for Libraries
2022-10-13 02:23:13 -07:00
SurfaceHostingComponent
Remove clang-format opt-out for Libraries
2022-10-13 02:23:13 -07:00
Text
Add a nil check to prevent a crash (#35941)
2023-01-24 03:57:45 -08:00
TurboModule
Fix TurboModuleRegistry TS type (#35885)
2023-01-19 05:56:51 -08:00
Types
Fixup TS Organization (#35169)
2022-11-02 14:58:37 -07:00
TypeSafety
chore: RCTConvert - allocate array with capacity (#35490)
2022-11-28 07:29:04 -08:00
Utilities
Getting rid of Toast in Dev Loading View post Native Module is released (#35888)
2023-01-19 21:15:03 -08:00
vendor
refactor(react-native/polyfills): rename package to @react-native/js-polyfills and align version
2022-12-05 18:34:33 -08:00
Vibration
Fix Vibration.vibrate() allowing null params
2022-12-14 15:23:12 -08:00
WebPerformance
Use a more robust method of finding out which events to report
2023-01-04 08:57:40 -08:00
WebSocket
Log Abnormal Closes to Metro Websocket
2022-10-26 20:09:32 -07:00
Wrapper
Remove clang-format opt-out for Libraries
2022-10-13 02:23:13 -07:00
YellowBox
ESM LogBox
2023-01-03 18:09:06 -08:00
.npmignore
npmignore: ignore tests and fixtures
2018-02-27 08:42:14 -08:00
Promise.js
Remove nonstandard Promise.prototype.done implementation
2022-05-05 03:55:10 -07:00
promiseRejectionTrackingOptions.js
Update copyright headers from Facebook to Meta
2021-12-30 15:11:21 -08:00
UTFSequence.js
Add newline to UTFSequence
2023-01-19 14:04:23 -08:00