mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
bd2b7d6c03
Summary: # Disclaimer: I might be missing something as the solution I implemented here seems like something that was considered by original author. If this solution isn't good, I have a plan B. # Problem: `onDismiss` prop isn't being called once the modal is dismissed, this diff fixes it. Also I've noticed that `onDismiss` is meant to only work on iOS, why is that? By landing this diff, it'll be called on Android as well so we need to change the docs (https://facebook.github.io/react-native/docs/modal.html#ondismiss). ## Video that shows the problem Following code is in playground.js P70222409 which just increments number everytime onDismiss is called {F166303269} Reviewed By: shergin Differential Revision: D16109536 fbshipit-source-id: 3fba56f5671912387b217f03b613dffd89614c9d
119 lines
3.2 KiB
JavaScript
119 lines
3.2 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
import codegenNativeComponent from '../Utilities/codegenNativeComponent';
|
|
import type {
|
|
WithDefault,
|
|
BubblingEventHandler,
|
|
DirectEventHandler,
|
|
Int32,
|
|
} from '../Types/CodegenTypes';
|
|
|
|
import type {ViewProps} from '../Components/View/ViewPropTypes';
|
|
|
|
type OrientationChangeEvent = $ReadOnly<{|
|
|
orientation: 'portrait' | 'landscape',
|
|
|}>;
|
|
|
|
type NativeProps = $ReadOnly<{|
|
|
...ViewProps,
|
|
|
|
/**
|
|
* The `animationType` prop controls how the modal animates.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#animationtype
|
|
*/
|
|
animationType?: WithDefault<'none' | 'slide' | 'fade', 'none'>,
|
|
|
|
/**
|
|
* The `presentationStyle` prop controls how the modal appears.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#presentationstyle
|
|
*/
|
|
presentationStyle?: WithDefault<
|
|
'fullScreen' | 'pageSheet' | 'formSheet' | 'overFullScreen',
|
|
'fullScreen',
|
|
>,
|
|
|
|
/**
|
|
* The `transparent` prop determines whether your modal will fill the
|
|
* entire view.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#transparent
|
|
*/
|
|
transparent?: WithDefault<boolean, false>,
|
|
|
|
/**
|
|
* The `hardwareAccelerated` prop controls whether to force hardware
|
|
* acceleration for the underlying window.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#hardwareaccelerated
|
|
*/
|
|
hardwareAccelerated?: WithDefault<boolean, false>,
|
|
|
|
/**
|
|
* The `onRequestClose` callback is called when the user taps the hardware
|
|
* back button on Android or the menu button on Apple TV.
|
|
*
|
|
* This is required on Apple TV and Android.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#onrequestclose
|
|
*/
|
|
onRequestClose?: ?DirectEventHandler<null>,
|
|
|
|
/**
|
|
* The `onShow` prop allows passing a function that will be called once the
|
|
* modal has been shown.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#onshow
|
|
*/
|
|
onShow?: ?DirectEventHandler<null>,
|
|
|
|
/**
|
|
* Deprecated. Use the `animationType` prop instead.
|
|
*/
|
|
animated?: WithDefault<boolean, false>,
|
|
|
|
/**
|
|
* The `supportedOrientations` prop allows the modal to be rotated to any of the specified orientations.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#supportedorientations
|
|
*/
|
|
supportedOrientations?: WithDefault<
|
|
$ReadOnlyArray<
|
|
| 'portrait'
|
|
| 'portrait-upside-down'
|
|
| 'landscape'
|
|
| 'landscape-left'
|
|
| 'landscape-right',
|
|
>,
|
|
'portrait',
|
|
>,
|
|
|
|
/**
|
|
* The `onOrientationChange` callback is called when the orientation changes while the modal is being displayed.
|
|
*
|
|
* See https://facebook.github.io/react-native/docs/modal.html#onorientationchange
|
|
*/
|
|
onOrientationChange?: ?DirectEventHandler<OrientationChangeEvent>,
|
|
|
|
/**
|
|
* The `identifier` is the unique number for identifying Modal components.
|
|
*/
|
|
identifier?: WithDefault<Int32, 0>,
|
|
|}>;
|
|
|
|
export default codegenNativeComponent<NativeProps>('ModalHostView', {
|
|
interfaceOnly: true,
|
|
paperComponentName: 'RCTModalHostView',
|
|
});
|