Files
react-native/ReactAndroid/src/main/java/com/facebook/react
Joshua Gross d183fd327b Improve MountingManager diagnostics around View removal
Summary:
It is possible (most recently, if there are bugs in LayoutAnimations, but also in general) to issue a `removeViewAt` MountItem that removes the incorrect view if, for whatever reason, the View hierarchy has become "corrupt"
and Views are out of order. I added two heuristics to catch if that happens: check the tag of the View being removed if possible, and ensure that all deleted views do not have a parent. This will turn weird visual glitches into
hard crashes, which we want once the UI has become corrupt.

My only concern here is with perf; maybe we could put these behind a debug-only flag or something, but it's probably not a huge deal.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D22130186

fbshipit-source-id: 0942b019c3449d68edfb9db1fe8130ea351d1d8f
2020-06-19 11:13:35 -07:00
..
2020-05-15 21:55:52 -07:00
2020-05-15 21:55:52 -07:00
2020-05-15 21:55:52 -07:00
2020-05-15 21:55:52 -07:00
2020-05-28 19:04:55 -07:00
2020-05-15 21:55:52 -07:00
2020-05-15 21:55:52 -07:00
2020-06-02 20:11:53 -07:00
2020-05-15 21:55:52 -07:00
2020-05-15 21:55:52 -07:00
2020-06-18 14:46:49 -07:00