mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Test User
0b4f4eec8e
Summary: This small PR updates the Flow types used in Dimensions. The following changes has been made: * generic types has been replaced with types from `NativeDeviceInfo` (which already were used in event subscription update) * ~simplification of `DisplayMetricsAndroid` by spreading via intersection with `DisplayMetrics` type and removing shared properties~ > I have tried both notations, but according to the lint, it looks like a Native Modules typing limitation which requires redundancy / code duplication in cases like this. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Changed] - update Dimensions API Flow types Pull Request resolved: https://github.com/facebook/react-native/pull/31898 Test Plan: Running `yarn flow` in the workspace yields no errors. Reviewed By: yungsters Differential Revision: D29932940 Pulled By: GijsWeterings fbshipit-source-id: bf97bb972964c585207e2450ccf71d932555e291
59 lines
1.3 KiB
JavaScript
59 lines
1.3 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow strict
|
|
* @format
|
|
*/
|
|
|
|
import type {TurboModule} from '../TurboModule/RCTExport';
|
|
import * as TurboModuleRegistry from '../TurboModule/TurboModuleRegistry';
|
|
|
|
export type DisplayMetricsAndroid = {|
|
|
width: number,
|
|
height: number,
|
|
scale: number,
|
|
fontScale: number,
|
|
densityDpi: number,
|
|
|};
|
|
|
|
export type DisplayMetrics = {|
|
|
width: number,
|
|
height: number,
|
|
scale: number,
|
|
fontScale: number,
|
|
|};
|
|
|
|
export type DimensionsPayload = {|
|
|
window?: DisplayMetrics,
|
|
screen?: DisplayMetrics,
|
|
windowPhysicalPixels?: DisplayMetricsAndroid,
|
|
screenPhysicalPixels?: DisplayMetricsAndroid,
|
|
|};
|
|
|
|
export interface Spec extends TurboModule {
|
|
+getConstants: () => {|
|
|
+Dimensions: DimensionsPayload,
|
|
+isIPhoneX_deprecated?: boolean,
|
|
|};
|
|
}
|
|
|
|
const NativeModule: Spec = TurboModuleRegistry.getEnforcing<Spec>('DeviceInfo');
|
|
let constants = null;
|
|
|
|
const NativeDeviceInfo = {
|
|
getConstants(): {|
|
|
+Dimensions: DimensionsPayload,
|
|
+isIPhoneX_deprecated?: boolean,
|
|
|} {
|
|
if (constants == null) {
|
|
constants = NativeModule.getConstants();
|
|
}
|
|
return constants;
|
|
},
|
|
};
|
|
|
|
export default NativeDeviceInfo;
|