mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Riccardo CipolleschiandFacebook GitHub Bot
5d175c6775
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36210 One of the circular dependencies we have in OSS was between React-Codegen and React-Fabric. React-Codegen generates component which has to depends on React-Fabric because they need to use the files contained in the `react/renderer/view` folder. React-Fabric contains some components that depends on RNCore, which was generated inside the React-Codegen folder. This change generates the RNCore components inside the `ReactCommon/react/renderer/components/rncore` folder, breaking the dependency as `rncore` folder is now contained by React-Fabric itself. **Fun Fact:** That's how it always should have been. There was already a line in the `.gitignore` to exclude the content of `ReactCommon/react/renderer/components/rncore` folder. I guess that with some of the refactoring/previous projects on Codegen, this requirements has slipped. ## Changelog: [iOS][Breaking] - generates RNCore components inside the ReactCommon folder and create a new pod for platform-specific ImageManager classes Reviewed By: sammy-SC, dmytrorykun Differential Revision: D43304641 fbshipit-source-id: ebb5033ce73dbcd03f880c3e204511fdce04b816
65 lines
2.4 KiB
Ruby
65 lines
2.4 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||
#
|
||
# This source code is licensed under the MIT license found in the
|
||
# LICENSE file in the root directory of this source tree.
|
||
|
||
require "json"
|
||
|
||
package = JSON.parse(File.read(File.join(__dir__, "..", "..", "..", "..", "..", "..", "package.json")))
|
||
version = package['version']
|
||
|
||
source = { :git => 'https://github.com/facebook/react-native.git' }
|
||
if version == '1000.0.0'
|
||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||
else
|
||
source[:tag] = "v#{version}"
|
||
end
|
||
|
||
folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'
|
||
boost_compiler_flags = '-Wno-documentation'
|
||
|
||
Pod::Spec.new do |s|
|
||
source_files = "**/*.{m,mm,cpp,h}"
|
||
header_search_paths = [
|
||
"\"$(PODS_ROOT)/boost\"",
|
||
"\"$(PODS_TARGET_SRCROOT)/../../../\"",
|
||
"\"$(PODS_TARGET_SRCROOT)\"",
|
||
"\"$(PODS_ROOT)/RCT-Folly\"",
|
||
]
|
||
|
||
s.name = "React-ImageManager"
|
||
s.version = version
|
||
s.summary = "Fabric for React Native."
|
||
s.homepage = "https://reactnative.dev/"
|
||
s.license = package["license"]
|
||
s.author = "Meta Platforms, Inc. and its affiliates"
|
||
s.platforms = { :ios => "12.4" }
|
||
s.source = source
|
||
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags
|
||
s.source_files = source_files
|
||
s.header_dir = "react/renderer/imagemanager"
|
||
|
||
if ENV['USE_FRAMEWORKS']
|
||
s.module_name = "React_ImageManager"
|
||
s.header_mappings_dir = "./"
|
||
header_search_paths = header_search_paths + [
|
||
"\"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers\"",
|
||
"\"$(PODS_ROOT)/DoubleConversion\"",
|
||
"\"${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers\"",
|
||
"\"${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers/react/renderer/graphics/platform/ios\"",
|
||
]
|
||
end
|
||
|
||
s.pod_target_xcconfig = {
|
||
"USE_HEADERMAP" => "NO",
|
||
"HEADER_SEARCH_PATHS" => header_search_paths.join(" "),
|
||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
|
||
}
|
||
|
||
s.dependency "RCT-Folly/Fabric"
|
||
s.dependency "React-Fabric"
|
||
s.dependency "React-Core/Default"
|
||
s.dependency "React-RCTImage"
|
||
end
|