mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Kudo Chien
65abc361bf
Summary: there are build errors happened when in [`generate_multiple_pod_projects`](https://blog.cocoapods.org/CocoaPods-1.7.0-beta/#multiple-xcodeproj-generation) mode and fabric is on. since we have multiple pod projects, there are something breaks. ### `-DRCT_NEW_ARCH_ENABLED=1` does not pass to `RCTAppSetupUtils.mm` because `installer.pods_project` is targeting `Pods.xcodeproj` but not `React-Core.xcodeproj`. we should use ` installer.target_installation_results.pod_target_installation_results` to deal with `generate_multiple_pod_projects` mode. ### fatal error: 'CompactValue.h' file not found ``` In file included from /path/to/react-native/packages/rn-tester/build/generated/ios/react/renderer/components/rncore/Props.cpp:11: In file included from /path/to/react-native/packages/rn-tester/Pods/Headers/Private/React-Codegen/react/renderer/components/rncore/Props.h:13: In file included from /path/to/react-native/packages/rn-tester/Pods/Headers/Private/React-Fabric/react/renderer/components/view/ViewProps.h:11: In file included from /path/to/react-native/packages/rn-tester/Pods/Headers/Private/React-Fabric/react/renderer/components/view/YogaStylableProps.h:10: /path/to/react-native/packages/rn-tester/Pods/Headers/Public/Yoga/yoga/YGStyle.h:16:10: fatal error: 'CompactValue.h' file not found #include "CompactValue.h" ^~~~~~~~~~~~~~~~ 1 error generated. ``` `Props.cpp` -> `YogaStylableProps.h` -> `YGStyle.h` -> `CompactValue.h` [`CompactValue.h` is internal private header for Yoga pod](https://github.com/facebook/react-native/blob/4eef075a583224ec9da6bbc4b42bc52508eb31be/ReactCommon/yoga/Yoga.podspec#L54-L56) where `React-Codegen` project cannot access to. ~there are some solutions toward this problem. one way is to make other yoga headers as public headers. i am not sure whether this solution would introduce any side effects. so i only make necessary projects to search yoga private headers.~ Update: a solution is to expose all yoga headers publicly. however, CocoaPods will put all public headers to module umbrella header. this will break YogaKit (swift) integration because swift module doesn't support c++. my pr is trying to expose all yoga headers to `$PODS_ROOT/Headers/Public/Yoga/yoga`, but use custom `module_map` to control which headers should be exposed to the swift module. CocoaPods's custom module_map has some limitation where cannot well support for both `use_frameworks!` mode and non use_frameworks! mode. there's a workaround to use `script_phase` copying the umbrella header to right place. ## Changelog [iOS] [Fixed] - Fix iOS build error when Podfile `generate_multiple_pod_projects=true` and Fabric is on Pull Request resolved: https://github.com/facebook/react-native/pull/33381 Test Plan: verify with rn-tester 1. add `generate_multiple_pod_projects` ```diff --- a/packages/rn-tester/Podfile +++ b/packages/rn-tester/Podfile @@ -5,7 +5,7 @@ platform :ios, '11.0' # Temporary solution to suppress duplicated GUID error. # Can be removed once we move to generate files outside pod install. -install! 'cocoapods', :deterministic_uuids => false +install! 'cocoapods', :generate_multiple_pod_projects => true, :deterministic_uuids => false USE_FRAMEWORKS = ENV['USE_FRAMEWORKS'] == '1' ``` 2. pod install and build rn-tester from xcode Reviewed By: cortinico Differential Revision: D34844041 Pulled By: dmitryrykun fbshipit-source-id: 93311b56d8e44491307a911ad58442f267c979eb
72 lines
3.0 KiB
Ruby
72 lines
3.0 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||
#
|
||
# This source code is licensed under the MIT license found in the
|
||
# LICENSE file in the root directory of this source tree.
|
||
|
||
package = JSON.parse(File.read(File.expand_path('../../package.json', __dir__)))
|
||
version = package['version']
|
||
|
||
source = { :git => ENV['INSTALL_YOGA_FROM_LOCATION'] || 'https://github.com/facebook/react-native.git' }
|
||
if version == '1000.0.0'
|
||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||
else
|
||
source[:tag] = "v#{version}"
|
||
end
|
||
|
||
Pod::Spec.new do |spec|
|
||
spec.name = 'Yoga'
|
||
spec.version = '1.14.0'
|
||
spec.license = { :type => 'MIT' }
|
||
spec.homepage = 'https://yogalayout.com'
|
||
spec.documentation_url = 'https://yogalayout.com/docs/'
|
||
|
||
spec.summary = 'Yoga is a cross-platform layout engine which implements Flexbox.'
|
||
spec.description = 'Yoga is a cross-platform layout engine enabling maximum collaboration within your team by implementing an API many designers are familiar with, and opening it up to developers across different platforms.'
|
||
|
||
spec.authors = 'Facebook'
|
||
spec.source = source
|
||
|
||
spec.module_name = 'yoga'
|
||
spec.header_dir = 'yoga'
|
||
spec.requires_arc = false
|
||
spec.pod_target_xcconfig = {
|
||
'DEFINES_MODULE' => 'YES'
|
||
}
|
||
spec.compiler_flags = [
|
||
'-fno-omit-frame-pointer',
|
||
'-fexceptions',
|
||
'-Wall',
|
||
'-Werror',
|
||
'-std=c++17',
|
||
'-fPIC'
|
||
]
|
||
|
||
# Pinning to the same version as React.podspec.
|
||
spec.platforms = { :ios => "12.4" }
|
||
|
||
# Set this environment variable when *not* using the `:path` option to install the pod.
|
||
# E.g. when publishing this spec to a spec repo.
|
||
source_files = 'yoga/**/*.{cpp,h}', 'Yoga-umbrella.h'
|
||
source_files = source_files.map { |file| File.join('ReactCommon/yoga', file) } if ENV['INSTALL_YOGA_WITHOUT_PATH_OPTION']
|
||
spec.source_files = source_files
|
||
|
||
spec.module_map = 'Yoga.modulemap'
|
||
|
||
# CocoaPods custom `module_map` + `header_dir` doesn't put the umbrella header in right place.
|
||
# Ideally, modulemap should be placed with the umbrella header, that would work for both use_frameworks! mode and non use_frameworks! mode.
|
||
# This script copy the umbrella header back to right place.
|
||
spec.script_phase = {
|
||
:name => 'Copy umbrella header',
|
||
:input_files => ["$PODS_ROOT/Headers/Public/Yoga/yoga/Yoga-umbrella.h"],
|
||
:output_files => ["$PODS_ROOT/Headers/Private/Yoga/Yoga-umbrella.h"],
|
||
:execution_position => :before_compile,
|
||
:shell_path => '/bin/bash',
|
||
|
||
# In use_frameworks! mode, the umbrella header will by copied to right place.
|
||
# This copy command will fail because "$PODS_ROOT/Headers/Public/Yoga/yoga/Yoga-umbrella.h" doesn't exist.
|
||
# The command is just a no-op in use_frameworks! mode.
|
||
:script => 'cp -f "$PODS_ROOT/Headers/Public/Yoga/yoga/Yoga-umbrella.h" "$PODS_ROOT/Headers/Private/Yoga/Yoga-umbrella.h" || true',
|
||
}
|
||
end
|