Files
react-native/Libraries/WebPerformance/PerformanceEntryReporter.cpp
T
Ruslan Shestopalyuk cf194aebfe Implement durationThreshold option for PerformanceObserver (#36152)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36152

[Changelog][Internal]

By [the W3C standard](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver/observe), `PerformanceObserver.observer` can optionally take a `durationThreshold` option, so that only entries with duration larger than the threshold are reported.

This diff adds support for this on the RN side, as well as unit tests for this feature on the JS side.

NOTE: The standard suggests that default value for this is 104s. I left it at 0 for now, as for the RN use cases t may be to too high (needs discussion).

Reviewed By: rubennorte

Differential Revision: D43154319

fbshipit-source-id: 0f9d435506f48d8e8521e408211347e8391d22fc
2023-02-16 06:21:43 -08:00

355 lines
10 KiB
C++

/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "PerformanceEntryReporter.h"
#include <cxxreact/JSExecutor.h>
#include <react/renderer/core/EventLogger.h>
#include "NativePerformanceObserver.h"
#include <unordered_map>
// All the unflushed entries beyond this amount will get discarded, with
// the amount of discarded ones sent back to the observers' callbacks as
// "droppedEntryCount" value
static constexpr size_t MAX_ENTRY_BUFFER_SIZE = 1024;
namespace facebook::react {
EventTag PerformanceEntryReporter::sCurrentEventTag_{0};
PerformanceEntryReporter &PerformanceEntryReporter::getInstance() {
static PerformanceEntryReporter instance;
return instance;
}
void PerformanceEntryReporter::setReportingCallback(
std::optional<AsyncCallback<>> callback) {
callback_ = callback;
}
void PerformanceEntryReporter::startReporting(PerformanceEntryType entryType) {
int entryTypeIdx = static_cast<int>(entryType);
reportingType_[entryTypeIdx] = true;
durationThreshold_[entryTypeIdx] = DEFAULT_DURATION_THRESHOLD;
}
void PerformanceEntryReporter::setDurationThreshold(
PerformanceEntryType entryType,
double durationThreshold) {
durationThreshold_[static_cast<int>(entryType)] = durationThreshold;
}
void PerformanceEntryReporter::stopReporting(PerformanceEntryType entryType) {
reportingType_[static_cast<int>(entryType)] = false;
}
GetPendingEntriesResult PerformanceEntryReporter::popPendingEntries() {
std::lock_guard<std::mutex> lock(entriesMutex_);
GetPendingEntriesResult res = {std::move(entries_), droppedEntryCount_};
entries_ = {};
droppedEntryCount_ = 0;
return res;
}
void PerformanceEntryReporter::logEntry(const RawPerformanceEntry &entry) {
const auto entryType = static_cast<PerformanceEntryType>(entry.entryType);
if (entryType == PerformanceEntryType::EVENT) {
eventCounts_[entry.name]++;
}
if (!isReportingType(entryType)) {
return;
}
if (entry.duration < durationThreshold_[entry.entryType]) {
// The entries duration is lower than the desired reporting threshold, skip
return;
}
std::lock_guard<std::mutex> lock(entriesMutex_);
if (entries_.size() == MAX_ENTRY_BUFFER_SIZE) {
// Start dropping entries once reached maximum buffer size.
// The number of dropped entries will be reported back to the corresponding
// PerformanceObserver callback.
droppedEntryCount_ += 1;
return;
}
entries_.emplace_back(entry);
if (entries_.size() == 1) {
// If the buffer was empty, it signals that JS side just has possibly
// consumed it and is ready to get more
scheduleFlushBuffer();
}
}
void PerformanceEntryReporter::mark(
const std::string &name,
double startTime,
double duration) {
// Register the mark for further possible "measure" lookup, as well as add
// it to a circular buffer:
PerformanceMark &mark = marksBuffer_[marksBufferPosition_];
marksBufferPosition_ = (marksBufferPosition_ + 1) % marksBuffer_.size();
if (!mark.name.empty()) {
// Drop off the oldest mark out of the queue, but only if that's indeed the
// oldest one
auto it = marksRegistry_.find(&mark);
if (it != marksRegistry_.end() && *it == &mark) {
marksRegistry_.erase(it);
}
}
mark.name = name;
mark.timeStamp = startTime;
marksRegistry_.insert(&mark);
logEntry(
{name,
static_cast<int>(PerformanceEntryType::MARK),
startTime,
duration,
std::nullopt,
std::nullopt,
std::nullopt});
}
void PerformanceEntryReporter::clearMarks(
const std::optional<std::string> &markName) {
if (markName) {
PerformanceMark mark{{*markName, 0}};
marksRegistry_.erase(&mark);
clearEntries([&markName](const RawPerformanceEntry &entry) {
return entry.entryType == static_cast<int>(PerformanceEntryType::MARK) &&
entry.name == markName;
});
} else {
marksRegistry_.clear();
clearEntries([](const RawPerformanceEntry &entry) {
return entry.entryType == static_cast<int>(PerformanceEntryType::MARK);
});
}
}
void PerformanceEntryReporter::measure(
const std::string &name,
double startTime,
double endTime,
const std::optional<double> &duration,
const std::optional<std::string> &startMark,
const std::optional<std::string> &endMark) {
double startTimeVal = startMark ? getMarkTime(*startMark) : startTime;
double endTimeVal = endMark ? getMarkTime(*endMark) : endTime;
double durationVal = duration ? *duration : endTimeVal - startTimeVal;
logEntry(
{name,
static_cast<int>(PerformanceEntryType::MEASURE),
startTimeVal,
durationVal,
std::nullopt,
std::nullopt,
std::nullopt});
}
void PerformanceEntryReporter::clearMeasures(
const std::optional<std::string> &measureName) {
if (measureName) {
clearEntries([&measureName](const RawPerformanceEntry &entry) {
return entry.entryType ==
static_cast<int>(PerformanceEntryType::MEASURE) &&
entry.name == measureName;
});
} else {
marksRegistry_.clear();
clearEntries([](const RawPerformanceEntry &entry) {
return entry.entryType == static_cast<int>(PerformanceEntryType::MEASURE);
});
}
}
double PerformanceEntryReporter::getMarkTime(
const std::string &markName) const {
PerformanceMark mark{{std::move(markName), 0}};
auto it = marksRegistry_.find(&mark);
if (it != marksRegistry_.end()) {
return (*it)->timeStamp;
} else {
return 0.0;
}
}
void PerformanceEntryReporter::event(
std::string name,
double startTime,
double duration,
double processingStart,
double processingEnd,
uint32_t interactionId) {
logEntry(
{std::move(name),
static_cast<int>(PerformanceEntryType::EVENT),
startTime,
duration,
processingStart,
processingEnd,
interactionId});
}
void PerformanceEntryReporter::clearEntries(
std::function<bool(const RawPerformanceEntry &)> predicate) {
int lastPos = entries_.size() - 1;
int pos = lastPos;
while (pos >= 0) {
if (predicate(entries_[pos])) {
entries_[pos] = entries_[lastPos];
lastPos--;
}
pos--;
}
entries_.resize(lastPos + 1);
}
void PerformanceEntryReporter::scheduleFlushBuffer() {
if (callback_) {
callback_->callWithPriority(SchedulerPriority::IdlePriority);
}
}
struct StrKey {
uint32_t key;
constexpr StrKey(const char *s)
: key(folly::hash::fnv32_buf(s, sizeof(s) - 1)) {}
constexpr bool operator==(const StrKey &rhs) const {
return key == rhs.key;
}
};
struct StrKeyHash {
constexpr size_t operator()(const StrKey &strKey) const {
return static_cast<size_t>(strKey.key);
}
};
// Supported events for reporting, see
// https://www.w3.org/TR/event-timing/#sec-events-exposed
// Not all of these are currently supported by RN, but we map them anyway for
// future-proofing.
static const std::unordered_map<StrKey, const char *, StrKeyHash>
SUPPORTED_EVENTS = {
{"topAuxClick", "auxclick"},
{"topClick", "click"},
{"topContextMenu", "contextmenu"},
{"topDblClick", "dblclick"},
{"topMouseDown", "mousedown"},
{"topMouseEnter", "mouseenter"},
{"topMouseLeave", "mouseleave"},
{"topMouseOut", "mouseout"},
{"topMouseOver", "mouseover"},
{"topMouseUp", "mouseup"},
{"topPointerOver", "pointerover"},
{"topPointerEnter", "pointerenter"},
{"topPointerDown", "pointerdown"},
{"topPointerUp", "pointerup"},
{"topPointerCancel", "pointercancel"},
{"topPointerOut", "pointerout"},
{"topPointerLeave", "pointerleave"},
{"topGotPointerCapture", "gotpointercapture"},
{"topLostPointerCapture", "lostpointercapture"},
{"topTouchStart", "touchstart"},
{"topTouchEnd", "touchend"},
{"topTouchCancel", "touchcancel"},
{"topKeyDown", "keydown"},
{"topKeyPress", "keypress"},
{"topKeyUp", "keyup"},
{"topBeforeInput", "beforeinput"},
{"topInput", "input"},
{"topCompositionStart", "compositionstart"},
{"topCompositionUpdate", "compositionupdate"},
{"topCompositionEnd", "compositionend"},
{"topDragStart", "dragstart"},
{"topDragEnd", "dragend"},
{"topDragEnter", "dragenter"},
{"topDragLeave", "dragleave"},
{"topDragOver", "dragover"},
{"topDrop", "drop"},
};
EventTag PerformanceEntryReporter::onEventStart(const char *name) {
if (!isReportingEvents()) {
return 0;
}
auto it = SUPPORTED_EVENTS.find(name);
if (it == SUPPORTED_EVENTS.end()) {
return 0;
}
const char *reportedName = it->second;
sCurrentEventTag_++;
if (sCurrentEventTag_ == 0) {
// The tag wrapped around (which is highly unlikely, but still)
sCurrentEventTag_ = 1;
}
auto timeStamp = JSExecutor::performanceNow();
{
std::lock_guard<std::mutex> lock(eventsInFlightMutex_);
eventsInFlight_.emplace(std::make_pair(
sCurrentEventTag_, EventEntry{reportedName, timeStamp, 0.0}));
}
return sCurrentEventTag_;
}
void PerformanceEntryReporter::onEventDispatch(EventTag tag) {
if (!isReportingEvents() || tag == 0) {
return;
}
auto timeStamp = JSExecutor::performanceNow();
{
std::lock_guard<std::mutex> lock(eventsInFlightMutex_);
auto it = eventsInFlight_.find(tag);
if (it != eventsInFlight_.end()) {
it->second.dispatchTime = timeStamp;
}
}
}
void PerformanceEntryReporter::onEventEnd(EventTag tag) {
if (!isReportingEvents() || tag == 0) {
return;
}
auto timeStamp = JSExecutor::performanceNow();
{
std::lock_guard<std::mutex> lock(eventsInFlightMutex_);
auto it = eventsInFlight_.find(tag);
if (it == eventsInFlight_.end()) {
return;
}
auto &entry = it->second;
auto &name = entry.name;
// TODO: Define the way to assign interaction IDs to the event chains
// (T141358175)
const uint32_t interactionId = 0;
event(
name,
entry.startTime,
timeStamp - entry.startTime,
entry.dispatchTime,
timeStamp,
interactionId);
eventsInFlight_.erase(it);
}
}
} // namespace facebook::react