mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Héctor Ramos
a68c418082
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/35038 React-jsi provides JSI to allow React Native to interface with JavaScriptCore. The hermes-engine Pod provides a second copy of JSI, as Hermes is built and linked statically with JSI. This second copy of JSI would lead to an [ODR Violation](https://en.cppreference.com/w/cpp/language/definition). To resolve this, when Hermes is enabled: - React-hermes and hermes-engine are installed. - React-jsc is not installed. - React-jsi continues to be installed. - React-jsi will not build JSI. - React-jsi will declare a dependency on hermes-engine. The result is that the JSI dependency for React Native is satisfied by hermes-engine, and there is no duplicate JSI library in the project. When Hermes is disabled: - React-jsi and React-jsc are installed. - React-hermes and hermes-engine are not installed. - React-jsi will build JSI. Changelog: [iOS][Changed] Resolve JSI ODR violation, make hermes-engine the JSI provider when Hermes is enabled Reviewed By: cipolleschi Differential Revision: D40334913 fbshipit-source-id: 409407a193a35cbd21b0e8778537b3627e4c54a2
107 lines
4.0 KiB
Ruby
107 lines
4.0 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
#
|
|
# This source code is licensed under the MIT license found in the
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
# It builds the codegen CLI if it is not present
|
|
#
|
|
# @parameter react_native_path: the path to the react native installation
|
|
# @parameter relative_installation_root: the path to the relative installation root of the pods
|
|
# @throws an error if it could not find the codegen folder.
|
|
def build_codegen!(react_native_path, relative_installation_root)
|
|
codegen_repo_path = "#{relative_installation_root}/#{react_native_path}/packages/react-native-codegen";
|
|
codegen_npm_path = "#{relative_installation_root}/#{react_native_path}/../react-native-codegen";
|
|
codegen_cli_path = ""
|
|
|
|
if Dir.exist?(codegen_repo_path)
|
|
codegen_cli_path = codegen_repo_path
|
|
elsif Dir.exist?(codegen_npm_path)
|
|
codegen_cli_path = codegen_npm_path
|
|
else
|
|
raise "[codegen] Couldn't not find react-native-codegen."
|
|
end
|
|
|
|
if !Dir.exist?("#{codegen_cli_path}/lib")
|
|
Pod::UI.puts "[Codegen] building #{codegen_cli_path}."
|
|
system("#{codegen_cli_path}/scripts/oss/build.sh")
|
|
end
|
|
end
|
|
|
|
# It generates an empty `ThirdPartyProvider`, required by Fabric to load the components
|
|
#
|
|
# @parameter react_native_path: path to the react native framework
|
|
# @parameter new_arch_enabled: whether the New Architecture is enabled or not
|
|
# @parameter codegen_output_dir: the output directory for the codegen
|
|
def checkAndGenerateEmptyThirdPartyProvider!(react_native_path, new_arch_enabled, codegen_output_dir)
|
|
return if new_arch_enabled
|
|
|
|
relative_installation_root = Pod::Config.instance.installation_root.relative_path_from(Pathname.pwd)
|
|
|
|
output_dir = "#{relative_installation_root}/#{codegen_output_dir}"
|
|
|
|
provider_h_path = "#{output_dir}/RCTThirdPartyFabricComponentsProvider.h"
|
|
provider_cpp_path ="#{output_dir}/RCTThirdPartyFabricComponentsProvider.cpp"
|
|
|
|
if(!File.exist?(provider_h_path) || !File.exist?(provider_cpp_path))
|
|
# build codegen
|
|
build_codegen!(react_native_path, relative_installation_root)
|
|
|
|
# Just use a temp empty schema list.
|
|
temp_schema_list_path = "#{output_dir}/tmpSchemaList.txt"
|
|
File.open(temp_schema_list_path, 'w') do |f|
|
|
f.write('[]')
|
|
f.fsync
|
|
end
|
|
|
|
Pod::UI.puts '[Codegen] generating an empty RCTThirdPartyFabricComponentsProvider'
|
|
Pod::Executable.execute_command(
|
|
'node',
|
|
[
|
|
"#{relative_installation_root}/#{react_native_path}/scripts/generate-provider-cli.js",
|
|
"--platform", 'ios',
|
|
"--schemaListPath", temp_schema_list_path,
|
|
"--outputDir", "#{output_dir}"
|
|
])
|
|
File.delete(temp_schema_list_path) if File.exist?(temp_schema_list_path)
|
|
end
|
|
end
|
|
|
|
def run_codegen!(
|
|
app_path,
|
|
config_file_dir,
|
|
new_arch_enabled: false,
|
|
disable_codegen: false,
|
|
react_native_path: "../node_modules/react-native",
|
|
fabric_enabled: false,
|
|
hermes_enabled: true,
|
|
codegen_output_dir: 'build/generated/ios',
|
|
config_key: 'codegenConfig',
|
|
package_json_file: '~/app/package.json',
|
|
folly_version: '2021.07.22.00',
|
|
codegen_utils: CodegenUtils.new()
|
|
)
|
|
|
|
if new_arch_enabled
|
|
codegen_utils.use_react_native_codegen_discovery!(
|
|
disable_codegen,
|
|
app_path,
|
|
:react_native_path => react_native_path,
|
|
:fabric_enabled => fabric_enabled,
|
|
:hermes_enabled => hermes_enabled,
|
|
:config_file_dir => config_file_dir,
|
|
:codegen_output_dir => codegen_output_dir,
|
|
:config_key => config_key,
|
|
:folly_version => folly_version
|
|
)
|
|
else
|
|
# Generate a podspec file for generated files.
|
|
# This gets generated in use_react_native_codegen_discovery when codegen discovery is enabled.
|
|
react_codegen_spec = codegen_utils.get_react_codegen_spec(
|
|
package_json_file,
|
|
:fabric_enabled => fabric_enabled,
|
|
:hermes_enabled => hermes_enabled
|
|
)
|
|
codegen_utils.generate_react_codegen_podspec!(react_codegen_spec, codegen_output_dir)
|
|
end
|
|
end
|