mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Daniel Leong
c7c263dda8
Summary: Some custom logic is applied to workaround a platform bug where velocity may be incorrect on Android P. [The bug in question](https://issuetracker.google.com/issues/112385925) appears to have been fixed before Android `Q` was released, so we shouldn't *need* to apply the workaround on other versions. As described in https://github.com/facebook/react-native/issues/34226 the workaround can adversely affect certain scroll behaviors, which can easily be reproduced when you briefly scroll one direction then quickly fling the opposite direction (see the video in the linked ticket). This PR changes the workaround to *only* be applied on Android P, in order to avoid causing weird scroll behavior on versions that are not actually affected by the bug the workaround is working around. ## Changelog ``` [Android] [Fixed] - Fix occasionally incorrect ScrollView fling behavior ``` Pull Request resolved: https://github.com/facebook/react-native/pull/34233 Test Plan: - Repro the strange fling behavior in the current version (See video attached in https://github.com/facebook/react-native/issues/34226) - Verify that the string fling behavior is fixed with this patch - Verify that fling behavior still works as expected on Android versions affected by the [original bug](https://issuetracker.google.com/issues/112385925), and those immediately following it (to verify that the bug being worked around was, in fact, fixed as expected). Reviewed By: javache Differential Revision: D38287277 Pulled By: ryancat fbshipit-source-id: 2c786872c4d41655b3849bb92e02f1f16c663b41
Building React Native for Android
See the Building from Source guide on the React Native website.
Running tests
When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing guide on the React Native website.