mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet NaraandFacebook GitHub Bot
cab16352c7
Summary: ## iOS On iOS: - All props come from ViewManagers - All HostComponent ViewManagers extend <View/> ViewManager https://pxl.cl/1SxdF Therefore, it's safe to have all HostComponent Static View Configs extend <View/> Static View Config. ## Android On Android, the model is a bit more complicated: https://pxl.cl/1Vmp5 Takeaways: - Props come from Shadow Nodes **and** ViewManagers - Nearly all HostComponent ViewManagers extend BaseViewManager. But, that's not <View/>'s ViewManager. - <View/>'s ViewManager is [ReactViewManager](https://fburl.com/code/0zalv8zk), which is a descendent of BaseViewManager, and declares its own ReactProps. So, it's not safe to have all Android HostComponent Static View Configs to extend <View/>'s Static View Config: 1. No components actualy incorportate <View/>'s props 2. Some components don't even incorporate BaseViewManager's props. ## Changes In this diff, I removed ReactNativeViewViewConfig, and introduced a new view config called PlatformBaseViewConfig. This ViewConfig partial will capture all the props available on all HostComponents on **both** platforms. This may not necessarily be the props made available on <View/>. The only components that don't extend the base platform props are: RCTTextInlineImage. What we do with these components is TBD. Changelog: [Internal] Reviewed By: yungsters Differential Revision: D32187832 fbshipit-source-id: 9a057abb3f58801615891c21e42ad4cfa5c69f21