mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
ba18ee9b87
Summary: There is a mixed usage of `folly::make_unique` and `std::make_unique`. Soon, `folly::make_unique` may be removed (see [this PR](https://github.com/facebook/folly/pull/1150)). Since `react-native` only supports C++14-compilers and later, switch to always using `std::make_unique`. ## Changelog [Internal] [Removed] - Replace folly::make_unique with std::make_unique Pull Request resolved: https://github.com/facebook/react-native/pull/26730 Test Plan: Running the existing test suite. No change in behavior is expected. Joshua Gross: buck install -r fb4a, make sure MP Home and forced teardown works okay on android Reviewed By: shergin Differential Revision: D18062400 Pulled By: JoshuaGross fbshipit-source-id: 978ca794c7e972db872a8dcc57c31bdec7451481
42 lines
1.2 KiB
Plaintext
42 lines
1.2 KiB
Plaintext
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "JSCExecutorFactory.h"
|
|
|
|
#import <React/RCTLog.h>
|
|
#import <jsi/JSCRuntime.h>
|
|
|
|
#import<memory>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
std::unique_ptr<JSExecutor> JSCExecutorFactory::createJSExecutor(
|
|
std::shared_ptr<ExecutorDelegate> delegate,
|
|
std::shared_ptr<MessageQueueThread> __unused jsQueue) {
|
|
auto installBindings = [runtimeInstaller=runtimeInstaller_](jsi::Runtime &runtime) {
|
|
react::Logger iosLoggingBinder = [](const std::string &message, unsigned int logLevel) {
|
|
_RCTLogJavaScriptInternal(
|
|
static_cast<RCTLogLevel>(logLevel),
|
|
[NSString stringWithUTF8String:message.c_str()]);
|
|
};
|
|
react::bindNativeLogger(runtime, iosLoggingBinder);
|
|
// Wrap over the original runtimeInstaller
|
|
if (runtimeInstaller) {
|
|
runtimeInstaller(runtime);
|
|
}
|
|
};
|
|
return std::make_unique<JSIExecutor>(
|
|
facebook::jsc::makeJSCRuntime(),
|
|
delegate,
|
|
JSIExecutor::defaultTimeoutInvoker,
|
|
std::move(installBindings));
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|