Files
react-native/Libraries
Janic Duplessis c5c79e5d71 Release underlying resources when JS instance in GC'ed on iOS (#24405)
Summary:
Our Blob implementation was very problematic because it didn't release its underlying resource when the JS instance was dealocated. The main issue is that the fetch polyfill uses blobs by default if the module is available, which causes large memory leaks.

This fixes it by using the new jsi infra to attach a `jsi::HostObject` (`BlobCollector`)  to `Blob` instances. This way when the `Blob` is collected, the `BlobCollector` also gets collected. Using the `jsi::HostObject` dtor we can schedule the cleanup of native resources. This is definitely not the ideal solution but otherwise it would require rewriting the whole module using TurboModules + jsi.

Fixes #23801, #20352, #21092

[General] [Fixed] - [Blob] Release underlying resources when JS instance in GC'ed
Pull Request resolved: https://github.com/facebook/react-native/pull/24405

Differential Revision: D15237418

Pulled By: cpojer

fbshipit-source-id: 00a94a54b0b172fbc62324364b753d192ac7016a
2019-05-07 02:03:57 -07:00
..
2018-12-11 20:01:00 -08:00
2019-05-03 11:43:10 -07:00
2019-04-08 09:15:14 -07:00
2018-10-31 01:37:26 -07:00
2019-03-19 10:24:52 -07:00
2019-03-14 07:00:27 -07:00