mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Moti Zilberman
3271e57c75
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52813 Changelog: [General][Changed] CDP backend now accepts addBinding and removeBinding methods earlier, before a Runtime exists. Allows managing CDP binding subscriptions at any point in time, including at the very beginning of a session when a `RuntimeAgent` doesn't yet exist (due to `registerRuntime` not having been called yet). "Adding" a binding with the `Runtime.addBinding` method is actually two actions in one: 1. Subscribing the current session to events from a particular binding name, from one or more Runtime(s) that may exist now or in the future (optionally targetable by execution context ID/name). 2. Installing a JSI function with the given `name` on the global object of the targeted Runtime(s), if they exist at the time of the method call. NOTE: "Removing" a binding only involves managing the subscription and never causes the corresponding JSI function to be uninstalled - presumably because it may have been captured by user code anyway. We currently do both (1) and (2) in `RuntimeAgent`, but this means subscriptions can't be managed before a `RuntimeTarget` has been created, which can cause problems if we want to set up certain bindings programmatically during React Native's initialisation. As this is an unnecessary restriction, here we move (1) to `HostAgent` and keep only (2) in `RuntimeAgent`. Reviewed By: huntie Differential Revision: D78739067 fbshipit-source-id: 9a39f4503d1b5e7c7a6e4c80dfbaabdd2549fb8d