mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet Nara
0e0d2e84f5
Summary: ## Context Every time we call RCTNetworking.sendRequest(), we [set up six event listeners inside XMLHttpRequest](https://fburl.com/diffusion/85k6ou5w) by calling RCTNetworking.addListener(). Seeing how RCTNetworking.addListener() is implemented, each call results in two async NativeModule call: [one to addListener()](https://fburl.com/diffusion/ng21jek6), and [another to removeEventListener()](https://fburl.com/diffusion/nua3y973). For RCTNetworking, both of these NativeModule calls are unnecessary, as explained in D24272663 (https://github.com/facebook/react-native/commit/dabca52f77799bcdedb6b0ec44b1f6297483a46d) > RCTNetworking.startObserving and RCTNetworking.stopObserving don't exist. The main purpose of RCTEventEmitter.addListener is to call these methods, and increment the _listeners counter, so that we can start dispatching events when _listeners > 0. In D24272560 (https://github.com/facebook/react-native/commit/82187bfb6b54fdffc5dadaa56e8bf97d2209708a), I made RCTEventEmitter dispatch events even when _listeners <= 0. This is sufficient for us to stop calling these two RCTNetworking methods entirely. Therefore, this experiment gets rid of on average 6-8 NativeModule method calls for every network call we make in React Native on iOS. Reviewed By: PeteTheHeat Differential Revision: D25618704 fbshipit-source-id: 0da20475a0882ed737cf32de27f266fd2cd016af
64 lines
1.5 KiB
JavaScript
64 lines
1.5 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow strict-local
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
import NativeEventEmitter from '../EventEmitter/NativeEventEmitter';
|
|
import NativeNetworkingIOS from './NativeNetworkingIOS';
|
|
import type {NativeResponseType} from './XMLHttpRequest';
|
|
import convertRequestBody from './convertRequestBody';
|
|
import type {RequestBody} from './convertRequestBody';
|
|
|
|
class RCTNetworking extends NativeEventEmitter {
|
|
constructor() {
|
|
super(NativeNetworkingIOS, {
|
|
__SECRET_DISABLE_CALLS_INTO_MODULE_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: true,
|
|
});
|
|
}
|
|
|
|
sendRequest(
|
|
method: string,
|
|
trackingName: string,
|
|
url: string,
|
|
headers: {...},
|
|
data: RequestBody,
|
|
responseType: NativeResponseType,
|
|
incrementalUpdates: boolean,
|
|
timeout: number,
|
|
callback: (requestId: number) => void,
|
|
withCredentials: boolean,
|
|
) {
|
|
const body = convertRequestBody(data);
|
|
NativeNetworkingIOS.sendRequest(
|
|
{
|
|
method,
|
|
url,
|
|
data: {...body, trackingName},
|
|
headers,
|
|
responseType,
|
|
incrementalUpdates,
|
|
timeout,
|
|
withCredentials,
|
|
},
|
|
callback,
|
|
);
|
|
}
|
|
|
|
abortRequest(requestId: number) {
|
|
NativeNetworkingIOS.abortRequest(requestId);
|
|
}
|
|
|
|
clearCookies(callback: (result: boolean) => void) {
|
|
NativeNetworkingIOS.clearCookies(callback);
|
|
}
|
|
}
|
|
|
|
module.exports = (new RCTNetworking(): RCTNetworking);
|