Spencer Ahrens c46353abe4 Force FbReactInstanceManagerAppJob.IdleExecutor to run in the UIThread ...

Summary:
`createReactContextInBackground` must be run on the UI Thread, so we update the DI annotation from `DefaultIdleExecutor` to `ForUiThread` so that happens.

Unclear why Infer didn't flag this. Asked [here](https://fb.workplace.com/groups/572076376174315/permalink/2661423100572955/).

Also adds an additional thread assert before setting `mHasStartedCreatingInitialContext = true` so that if a similar bug happens in the future, RN won't be completely hosed.

Reviewed By: mdvacca

Differential Revision: D16574901

fbshipit-source-id: 02ba63979904e9df9ef6d782aa7379cb44702508

2019-07-30 20:28:27 -07:00

..

com/facebook

Force FbReactInstanceManagerAppJob.IdleExecutor to run in the UIThread

2019-07-30 20:28:27 -07:00