mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
b5cd9e4db1
Summary: In some cases, the view class is the only that retains stored `props_` variable. At the same time the `[super updateProps:props oldProps:oldProps];` actually resets the pointer with a pointer to new props value which sometimes causes the deallocation of the old value. All that is okay unless the implementation of `updateProps:oldProps:` in superclasses stores a raw reference to an old value in the very beginning of the method (for convenience and perf reasons). So, to prevent preliminary deallocation of the old value pointed by `_props` we moved all `[super updateProps:props oldProps:oldProps];` calls to the end of overloaded methods. Reviewed By: mdvacca Differential Revision: D15770068 fbshipit-source-id: af36b3e70560ab00846cd26b0963bbc059e977bc
91 lines
3.2 KiB
Objective-C
91 lines
3.2 KiB
Objective-C
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <UIKit/UIKit.h>
|
|
|
|
#import <React/RCTComponentViewProtocol.h>
|
|
#import <React/RCTTouchableComponentViewProtocol.h>
|
|
#import <React/UIView+ComponentViewProtocol.h>
|
|
#import <react/components/view/ViewEventEmitter.h>
|
|
#import <react/components/view/ViewProps.h>
|
|
#import <react/core/EventEmitter.h>
|
|
#import <react/core/LayoutMetrics.h>
|
|
#import <react/core/Props.h>
|
|
|
|
NS_ASSUME_NONNULL_BEGIN
|
|
|
|
/**
|
|
* UIView class for <View> component.
|
|
*/
|
|
@interface RCTViewComponentView : UIView <RCTComponentViewProtocol, RCTTouchableComponentViewProtocol> {
|
|
@protected
|
|
facebook::react::LayoutMetrics _layoutMetrics;
|
|
facebook::react::SharedViewProps _props;
|
|
facebook::react::SharedViewEventEmitter _eventEmitter;
|
|
}
|
|
|
|
/**
|
|
* Represents the `UIView` instance that is being automatically attached to
|
|
* the component view and laid out using on `layoutMetrics` (especially `size`
|
|
* and `padding`) of the component.
|
|
* This view must not be a component view; it's just a convenient way
|
|
* to embed/bridge pure native views as component views.
|
|
* Defaults to `nil`. Assing `nil` to remove view as subview.
|
|
*/
|
|
@property (nonatomic, strong, nullable) UIView *contentView;
|
|
|
|
/**
|
|
* Provides access to `nativeId` prop of the component.
|
|
* It might be used by subclasses (which need to refer to the view from
|
|
* other platform-specific external views or systems by some id) or
|
|
* by debugging/inspection tools.
|
|
* Defaults to `nil`.
|
|
*/
|
|
@property (nonatomic, strong, nullable) NSString *nativeId;
|
|
|
|
/**
|
|
* Provides access to `foregroundColor` prop of the component.
|
|
* Must be used by subclasses only.
|
|
*/
|
|
@property (nonatomic, strong, nullable) UIColor *foregroundColor;
|
|
|
|
/**
|
|
* Returns the object - usually (sub)view - which represents this
|
|
* component view in terms of accessibility.
|
|
* All accessibility properties will be applied to this object.
|
|
* May be overridden in subclass which needs to be accessiblitywise
|
|
* transparent in favour of some subview.
|
|
* Defaults to `self`.
|
|
*/
|
|
@property (nonatomic, strong, nullable, readonly) NSObject *accessibilityElement;
|
|
|
|
/**
|
|
* Insets used when hit testing inside this view.
|
|
*/
|
|
@property (nonatomic, assign) UIEdgeInsets hitTestEdgeInsets;
|
|
|
|
/**
|
|
* Enforcing `call super` semantic for overridden methods from `RCTComponentViewProtocol`.
|
|
* The methods update the instance variables.
|
|
*/
|
|
- (void)updateProps:(facebook::react::Props::Shared const &)props
|
|
oldProps:(facebook::react::Props::Shared const &)oldProps NS_REQUIRES_SUPER;
|
|
- (void)updateEventEmitter:(facebook::react::EventEmitter::Shared const &)eventEmitter NS_REQUIRES_SUPER;
|
|
- (void)updateLayoutMetrics:(facebook::react::LayoutMetrics const &)layoutMetrics
|
|
oldLayoutMetrics:(facebook::react::LayoutMetrics const &)oldLayoutMetrics NS_REQUIRES_SUPER;
|
|
- (void)finalizeUpdates:(RNComponentViewUpdateMask)updateMask NS_REQUIRES_SUPER;
|
|
- (void)prepareForRecycle NS_REQUIRES_SUPER;
|
|
|
|
/*
|
|
* This is a fragment of temporary workaround that we need only temporary and will get rid of soon.
|
|
*/
|
|
- (NSString *)componentViewName_DO_NOT_USE_THIS_IS_BROKEN;
|
|
|
|
@end
|
|
|
|
NS_ASSUME_NONNULL_END
|