mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
eafa49d5a6
Summary:
In `StateReconciliationTest`, the way initializer lists are used to create null `ShadowNode`s causes this error on Visual Studio 2017 on Windows:
```cpp
auto result = (ShadowNode const *){nullptr};
```
---
```
StateReconciliationTest.cpp(35): error C4576: a parenthesized type followed by an init
ializer list is a non-standard explicit type conversion syntax
```
This change allows this test to compile in Visual Studio 2017, and the effected tests successfully compile and pass on Windows. They also compile and pass on Linux and macOS (both built with Clang)
## Changelog
Changelog: [Internal][Changed] - Fabric Tests: Change null ShadowNode creation in StateReconciliationTest
Pull Request resolved: https://github.com/facebook/react-native/pull/29899
Test Plan: The Fabric test suite passes on Windows after this change is made. I also tested it under macOS and Linux built with Clang and they both pass with this change made.
Reviewed By: sammy-SC
Differential Revision: D23592007
Pulled By: shergin
fbshipit-source-id: 7c6131736d478a0bf29d6c9475ef9149b7602dd6
178 lines
6.0 KiB
C++
178 lines
6.0 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <memory>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
|
|
#include <react/renderer/components/root/RootComponentDescriptor.h>
|
|
#include <react/renderer/components/view/ViewComponentDescriptor.h>
|
|
#include <react/renderer/element/ComponentBuilder.h>
|
|
#include <react/renderer/element/Element.h>
|
|
#include <react/renderer/element/testUtils.h>
|
|
|
|
#include <react/renderer/mounting/MountingCoordinator.h>
|
|
#include <react/renderer/mounting/ShadowTree.h>
|
|
#include <react/renderer/mounting/ShadowTreeDelegate.h>
|
|
|
|
using namespace facebook::react;
|
|
|
|
class DummyShadowTreeDelegate : public ShadowTreeDelegate {
|
|
public:
|
|
virtual void shadowTreeDidFinishTransaction(
|
|
ShadowTree const &shadowTree,
|
|
MountingCoordinator::Shared const &mountingCoordinator) const override{};
|
|
};
|
|
|
|
inline ShadowNode const *findDescendantNode(
|
|
ShadowNode const &shadowNode,
|
|
ShadowNodeFamily const &family) {
|
|
ShadowNode const *result = nullptr;
|
|
shadowNode.cloneTree(family, [&](ShadowNode const &oldShadowNode) {
|
|
result = &oldShadowNode;
|
|
return oldShadowNode.clone({});
|
|
});
|
|
return result;
|
|
}
|
|
|
|
inline ShadowNode const *findDescendantNode(
|
|
ShadowTree const &shadowTree,
|
|
ShadowNodeFamily const &family) {
|
|
ShadowNode const *result = nullptr;
|
|
|
|
shadowTree.tryCommit(
|
|
[&](RootShadowNode::Shared const &oldRootShadowNode) {
|
|
result = findDescendantNode(*oldRootShadowNode, family);
|
|
return nullptr;
|
|
},
|
|
false);
|
|
|
|
return result;
|
|
}
|
|
|
|
TEST(StateReconciliationTest, testStateReconciliation) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto shadowNodeA = std::shared_ptr<RootShadowNode>{};
|
|
auto shadowNodeAA = std::shared_ptr<ViewShadowNode>{};
|
|
auto shadowNodeAB = std::shared_ptr<ScrollViewShadowNode>{};
|
|
auto shadowNodeABA = std::shared_ptr<ViewShadowNode>{};
|
|
auto shadowNodeABB = std::shared_ptr<ViewShadowNode>{};
|
|
auto shadowNodeABC = std::shared_ptr<ViewShadowNode>{};
|
|
|
|
// clang-format off
|
|
auto element =
|
|
Element<RootShadowNode>()
|
|
.reference(shadowNodeA)
|
|
.finalize([](RootShadowNode &shadowNode){
|
|
shadowNode.sealRecursive();
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(shadowNodeAA),
|
|
Element<ScrollViewShadowNode>()
|
|
.reference(shadowNodeAB)
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(shadowNodeABA),
|
|
Element<ViewShadowNode>()
|
|
.reference(shadowNodeABB),
|
|
Element<ViewShadowNode>()
|
|
.reference(shadowNodeABC)
|
|
})
|
|
});
|
|
// clang-format on
|
|
|
|
auto shadowNode = builder.build(element);
|
|
|
|
auto rootShadowNodeState1 = shadowNode->ShadowNode::clone({});
|
|
|
|
auto &scrollViewComponentDescriptor = shadowNodeAB->getComponentDescriptor();
|
|
auto &family = shadowNodeAB->getFamily();
|
|
auto state1 = shadowNodeAB->getState();
|
|
auto shadowTreeDelegate = DummyShadowTreeDelegate{};
|
|
auto eventDispatcher = EventDispatcher::Shared{};
|
|
auto rootComponentDescriptor =
|
|
ComponentDescriptorParameters{eventDispatcher, nullptr, nullptr};
|
|
ShadowTree shadowTree{SurfaceId{11},
|
|
LayoutConstraints{},
|
|
LayoutContext{},
|
|
rootComponentDescriptor,
|
|
shadowTreeDelegate,
|
|
{}};
|
|
|
|
shadowTree.commit(
|
|
[&](RootShadowNode::Shared const &oldRootShadowNode) {
|
|
return std::static_pointer_cast<RootShadowNode>(rootShadowNodeState1);
|
|
},
|
|
true);
|
|
|
|
EXPECT_EQ(state1->getMostRecentState(), state1);
|
|
|
|
EXPECT_EQ(
|
|
findDescendantNode(*rootShadowNodeState1, family)->getState(), state1);
|
|
|
|
auto state2 = scrollViewComponentDescriptor.createState(
|
|
family, std::make_shared<ScrollViewState const>());
|
|
|
|
auto rootShadowNodeState2 =
|
|
shadowNode->cloneTree(family, [&](ShadowNode const &oldShadowNode) {
|
|
return oldShadowNode.clone({ShadowNodeFragment::propsPlaceholder(),
|
|
ShadowNodeFragment::childrenPlaceholder(),
|
|
state2});
|
|
});
|
|
|
|
EXPECT_EQ(
|
|
findDescendantNode(*rootShadowNodeState2, family)->getState(), state2);
|
|
|
|
shadowTree.commit(
|
|
[&](RootShadowNode::Shared const &oldRootShadowNode) {
|
|
return std::static_pointer_cast<RootShadowNode>(rootShadowNodeState2);
|
|
},
|
|
true);
|
|
|
|
EXPECT_EQ(state1->getMostRecentState(), state2);
|
|
EXPECT_EQ(state2->getMostRecentState(), state2);
|
|
|
|
auto state3 = scrollViewComponentDescriptor.createState(
|
|
family, std::make_shared<ScrollViewState const>());
|
|
|
|
auto rootShadowNodeState3 = rootShadowNodeState2->cloneTree(
|
|
family, [&](ShadowNode const &oldShadowNode) {
|
|
return oldShadowNode.clone({ShadowNodeFragment::propsPlaceholder(),
|
|
ShadowNodeFragment::childrenPlaceholder(),
|
|
state3});
|
|
});
|
|
|
|
EXPECT_EQ(
|
|
findDescendantNode(*rootShadowNodeState3, family)->getState(), state3);
|
|
|
|
shadowTree.commit(
|
|
[&](RootShadowNode::Shared const &oldRootShadowNode) {
|
|
return std::static_pointer_cast<RootShadowNode>(rootShadowNodeState3);
|
|
},
|
|
true);
|
|
|
|
EXPECT_EQ(findDescendantNode(shadowTree, family)->getState(), state3);
|
|
|
|
EXPECT_EQ(state1->getMostRecentState(), state3);
|
|
EXPECT_EQ(state2->getMostRecentState(), state3);
|
|
EXPECT_EQ(state3->getMostRecentState(), state3);
|
|
|
|
// This is the core part of the whole test.
|
|
// Here we commit the old tree but we expect that the state associated with
|
|
// the node will stay the same (newer that the old tree has).
|
|
shadowTree.commit(
|
|
[&](RootShadowNode::Shared const &oldRootShadowNode) {
|
|
return std::static_pointer_cast<RootShadowNode>(rootShadowNodeState2);
|
|
},
|
|
true);
|
|
|
|
EXPECT_EQ(findDescendantNode(shadowTree, family)->getState(), state3);
|
|
}
|