Files
react-native/ReactCommon/fabric/components/textinput/iostextinput/TextInputProps.cpp
T
Valentin Shergin 8fe6883fea Fabric: Fixed double-application of opacity and background-color props on TextInput
Summary:
These props are applied to `View`, therefore they most not be a part of base text attributes, so we reset them.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: mdvacca

Differential Revision: D19764144

fbshipit-source-id: a0d2900e3161c47b83114360c843fa85a4389f8a
2020-02-06 08:16:37 -08:00

88 lines
2.5 KiB
C++

/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "TextInputProps.h"
#include <react/attributedstring/conversions.h>
#include <react/components/iostextinput/propsConversions.h>
#include <react/core/propsConversions.h>
#include <react/graphics/conversions.h>
namespace facebook {
namespace react {
TextInputProps::TextInputProps(
TextInputProps const &sourceProps,
RawProps const &rawProps)
: ViewProps(sourceProps, rawProps),
BaseTextProps(sourceProps, rawProps),
traits(convertRawProp(rawProps, sourceProps.traits, {})),
paragraphAttributes(
convertRawProp(rawProps, sourceProps.paragraphAttributes, {})),
defaultValue(convertRawProp(
rawProps,
"defaultValue",
sourceProps.defaultValue,
{})),
placeholder(
convertRawProp(rawProps, "placeholder", sourceProps.placeholder, {})),
placeholderTextColor(convertRawProp(
rawProps,
"placeholderTextColor",
sourceProps.placeholderTextColor,
{})),
maxLength(
convertRawProp(rawProps, "maxLength", sourceProps.maxLength, {})),
cursorColor(
convertRawProp(rawProps, "cursorColor", sourceProps.cursorColor, {})),
selectionColor(convertRawProp(
rawProps,
"selectionColor",
sourceProps.selectionColor,
{})),
underlineColorAndroid(convertRawProp(
rawProps,
"underlineColorAndroid",
sourceProps.underlineColorAndroid,
{})),
text(convertRawProp(rawProps, "text", sourceProps.text, {})){};
TextAttributes TextInputProps::getEffectiveTextAttributes() const {
auto result = TextAttributes::defaultTextAttributes();
result.apply(textAttributes);
/*
* These props are applied to `View`, therefore they must not be a part of
* base text attributes.
*/
result.backgroundColor = clearColor();
result.opacity = 1;
return result;
}
ParagraphAttributes TextInputProps::getEffectiveParagraphAttributes() const {
auto result = paragraphAttributes;
if (!traits.multiline) {
result.maximumNumberOfLines = 1;
}
return result;
}
#ifdef ANDROID
folly::dynamic TextInputProps::getDynamic() const {
folly::dynamic props = folly::dynamic::object();
props["value"] = value;
return props;
}
#endif
} // namespace react
} // namespace facebook